-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
First, amazing work! 👏
Second, I recommend changing the transcript attribute to return a full URL, not just a path. This makes it a little easier to use because the client only needs the JSON, not information about where the JSON came from.
This does slightly complicate generation since you either have to hardcode in the domain (drake no) or make it reliant on an env var (drake aha) but that seems like a worthwhile trade-off.
Happy to submit this as a PR if desired.
Line 24 in 13d34f3
| jq "map(if .case_id == \"$case\" then . + {\"transcript\": \"/transcripts/$case.srt\"} else . end)" arguments.json > "$tmp" && mv "$tmp" arguments.json |
Metadata
Metadata
Assignees
Labels
No labels