Skip to content

Make "transcript" a full URL, not just a path #5

@reefdog

Description

@reefdog

First, amazing work! 👏

Second, I recommend changing the transcript attribute to return a full URL, not just a path. This makes it a little easier to use because the client only needs the JSON, not information about where the JSON came from.

This does slightly complicate generation since you either have to hardcode in the domain (drake no) or make it reliant on an env var (drake aha) but that seems like a worthwhile trade-off.

Happy to submit this as a PR if desired.

jq "map(if .case_id == \"$case\" then . + {\"transcript\": \"/transcripts/$case.srt\"} else . end)" arguments.json > "$tmp" && mv "$tmp" arguments.json

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions