Bool simplifications breaks valid comparisons

[adisbladis]

Expressions like:

v: v == true

Are erroneously simplified as:

v: v

Which breaks when v is not of type bool.

[saygo-png]

In addition this is also occurs when v can be undefined and or is used to provide a fallback.

(foo.bar or false) == true

This is actively suggesting incorrect code.

[irgolic]

This fix is an improvement 99% of the time, and most linters (e.g., ruff) suggest it.

It's definitely an unsafe fix though, and makes me not trust running the linter without closely reviewing its changes.

Ideally the linter would automatically apply safe fixes, mention the availability of unsafe fixes, and apply unsafe fixes only when explicitly requested.

[sanskarRaghuvanshi]

Hi @adisbladis! Is this issue still available? I'd like to work on it.