Prepare 4.x.x branch for future releases

Author: raju-opti

.github/workflows/integration_test.yml

@@ -37,18 +37,17 @@ jobs:
         SDK: javascript
         FULLSTACK_TEST_REPO: ${{ inputs.FULLSTACK_TEST_REPO }}
         BUILD_NUMBER: ${{ github.run_id }}
-        TESTAPP_BRANCH: master
+        TESTAPP_BRANCH: test-4.x.x
         GITHUB_TOKEN: ${{ secrets.CI_USER_TOKEN }}
-        TRAVIS_EVENT_TYPE: ${{ github.event_name }}
+        EVENT_TYPE: ${{ github.event_name }}
         GITHUB_CONTEXT: ${{ toJson(github) }}
-        TRAVIS_REPO_SLUG: ${{ github.repository }}
-        TRAVIS_PULL_REQUEST_SLUG: ${{ github.repository }}
+        #REPO_SLUG: ${{ github.repository }}
+        PULL_REQUEST_SLUG: ${{ github.repository }}
         UPSTREAM_REPO: ${{ github.repository }}
-        TRAVIS_COMMIT: ${{ github.sha }}
-        TRAVIS_PULL_REQUEST_SHA: ${{ github.event.pull_request.head.sha }}
-        TRAVIS_PULL_REQUEST: ${{ github.event.pull_request.number }}
+        PULL_REQUEST_SHA: ${{ github.event.pull_request.head.sha }}
+        PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
         UPSTREAM_SHA: ${{ github.sha }}
-        TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
+        TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
         EVENT_MESSAGE: ${{ github.event.message }}
         HOME: 'home/runner'
       run: |

.github/workflows/javascript.yml

@@ -2,13 +2,13 @@ name: Javascript
 
 on:
   push:
-    branches: [ master ]
+    branches: [ 4.x.x ]
   pull_request:
-    branches: [ master ]
+    branches: [ 4.x.x ]
 
 jobs:
   lint_markdown_files:
-    uses: optimizely/javascript-sdk/.github/workflows/lint_markdown.yml@master
+    uses: optimizely/javascript-sdk/.github/workflows/lint_markdown.yml@4.x.x
 
   lint:
     runs-on: ubuntu-latest
@@ -27,13 +27,13 @@ jobs:
         npm run lint
 
   integration_tests:
-    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
+    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@4.x.x
     secrets:
       CI_USER_TOKEN: ${{ secrets.CI_USER_TOKEN }}
       TRAVIS_COM_TOKEN: ${{ secrets.TRAVIS_COM_TOKEN }}
 
   fullstack_production_suite:
-    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@master
+    uses: optimizely/javascript-sdk/.github/workflows/integration_test.yml@4.x.x
     with:
       FULLSTACK_TEST_REPO: ProdTesting
     secrets:
@@ -66,7 +66,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '8', '9', '10', '12', '14' ]
+        node: [ '8', '9', '10', '12', '14', '16', '18' ]
     steps:
     - uses: actions/checkout@v3
     - name: Set up Node ${{ matrix.node }}

packages/optimizely-sdk/lib/core/bucketer/index.tests.js

@@ -355,7 +355,7 @@ describe('lib/core/bucketer', function () {
       it('should return an error if it cannot generate the hash value', function () {
         assert.throws(function () {
           bucketer._generateBucketValue(null);
-        }, sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, "Cannot read property 'length' of null"));
+        }, new RegExp('^' + sprintf(ERROR_MESSAGES.INVALID_BUCKETING_ID, 'BUCKETER', null, '')));
       });
     });