update: Updated deprecated dependency for React Native (#666)

zashraf1985 · web-flow · commit 5ad5fd26efd7 · 2021-05-24T16:28:00.000-07:00
## Summary
`Datafile Manager` and `Event Processor` packages use `@react-native-community/async-storage` to support datafile and event caching in React Native Mobile Apps. This package is deprecated and moved to `@react-native-async-storage/async-storage`. This PR updates this dependency in both the packages.

## Test plan
- Updated all unit tests
- Manually tested thoroughly with both iOS and Android React Native Apps
diff --git a/.travis.yml b/.travis.yml
@@ -82,7 +82,7 @@ jobs:
     - <<: *packagetest
       before_install: cd packages/logging
     - <<: *packagetest
-      before_script: npm install "@react-native-community/async-storage"
+      before_script: npm install "@react-native-async-storage/async-storage"
       before_install: cd packages/datafile-manager
 
     - stage: 'Source Clear'
diff --git a/packages/datafile-manager/CHANGELOG.md b/packages/datafile-manager/CHANGELOG.md
@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 Changes that have landed but are not yet released.
+- Replaced the deprecated `@react-native-community/async-storage` with `@react-native-async-storage/async-storage`.
 
 ## [0.8.0] - September 1, 2020
 
diff --git a/packages/datafile-manager/README.md b/packages/datafile-manager/README.md
@@ -16,9 +16,9 @@ Platform-specific minimum supported versions:
 npm i @optimizely/js-sdk-datafile-manager
 ```
 
-For React Native, installation of peer dependency `@react-native-community/async-storage` is also required:
+For React Native, installation of peer dependency `@react-native-async-storage/async-storage` is also required:
 ```sh
-npm i @react-native-community/async-storage
+npm i @react-native-async-storage/async-storage
 ```
 
 ## Usage
diff --git a/packages/datafile-manager/__mocks__/@react-native-async-storage/async-storage.ts b/packages/datafile-manager/__mocks__/@react-native-async-storage/async-storage.ts
diff --git a/packages/datafile-manager/package-lock.json b/packages/datafile-manager/package-lock.json
diff --git a/packages/datafile-manager/package.json b/packages/datafile-manager/package.json
@@ -45,15 +45,15 @@
     "prettier": "^1.19.1",
     "ts-jest": "^24.0.0",
     "typescript": "3.3.3333",
-    "@react-native-community/async-storage": "^1.2.0"
+    "@react-native-async-storage/async-storage": "^1.2.0"
   },
   "dependencies": {
     "@optimizely/js-sdk-logging": "^0.1.0",
     "@optimizely/js-sdk-utils": "^0.4.0",
     "decompress-response": "^4.2.1"
   },
   "peerDependencies": {
-    "@react-native-community/async-storage": "^1.2.0"
+    "@react-native-async-storage/async-storage": "^1.2.0"
   },
   "scripts": {
     "lint": "tsc --noEmit && eslint --fix 'src/**/*.ts' '__test__/**/*.ts'",
diff --git a/packages/datafile-manager/src/reactNativeAsyncStorageCache.ts b/packages/datafile-manager/src/reactNativeAsyncStorageCache.ts
@@ -13,9 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-import AsyncStorage from '@react-native-community/async-storage';
-
+import AsyncStorage from '@react-native-async-storage/async-storage';
 import PersistentKeyValueCache from './persistentKeyValueCache';
 
 export default class ReactNativeAsyncStorageCache implements PersistentKeyValueCache {
diff --git a/packages/event-processor/CHANGELOG.MD b/packages/event-processor/CHANGELOG.MD
@@ -6,6 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 Changes that have landed but are not yet released.
+- Replaced the deprecated `@react-native-community/async-storage` with `@react-native-async-storage/async-storage`.
 
 ## [0.8.0] - November 10th, 2020
 
diff --git a/packages/event-processor/__mocks__/@react-native-async-storage/async-storage.ts b/packages/event-processor/__mocks__/@react-native-async-storage/async-storage.ts
diff --git a/packages/event-processor/__tests__/reactNativeEventsStore.spec.ts b/packages/event-processor/__tests__/reactNativeEventsStore.spec.ts
@@ -16,7 +16,7 @@
 /// <reference types="jest" />
 
 import { ReactNativeEventsStore } from '../src/reactNativeEventsStore'
-import AsyncStorage from '../__mocks__/@react-native-community/async-storage'
+import AsyncStorage from '../__mocks__/@react-native-async-storage/async-storage'
 
 const STORE_KEY = 'test-store'
 
diff --git a/packages/event-processor/__tests__/v1EventProcessor.react_native.spec.ts b/packages/event-processor/__tests__/v1EventProcessor.react_native.spec.ts
@@ -24,7 +24,7 @@ import {
 } from '../src/eventDispatcher'
 import { EventProcessor, ProcessableEvent } from '../src/eventProcessor'
 import { buildImpressionEventV1, makeBatchedEventV1 } from '../src/v1/buildEventV1'
-import AsyncStorage from '../__mocks__/@react-native-community/async-storage'
+import AsyncStorage from '../__mocks__/@react-native-async-storage/async-storage'
 import { triggerInternetState } from '../__mocks__/@react-native-community/netinfo'
 import { DefaultEventQueue } from '../src/eventQueue'
 
diff --git a/packages/event-processor/package-lock.json b/packages/event-processor/package-lock.json
diff --git a/packages/event-processor/package.json b/packages/event-processor/package.json
@@ -43,8 +43,8 @@
     "@optimizely/js-sdk-utils": "^0.4.0"
   },
   "devDependencies": {
-    "@react-native-community/async-storage": "^1.2.0",
     "@react-native-community/netinfo": "^5.9.4",
+    "@react-native-async-storage/async-storage": "^1.2.0",
     "@types/jest": "^24.0.9",
     "jest": "^23.6.0",
     "jest-localstorage-mock": "^2.4.0",
@@ -53,6 +53,6 @@
   },
   "peerDependencies": {
     "@react-native-community/netinfo": "5.9.4",
-    "@react-native-community/async-storage": "^1.2.0"
+    "@react-native-async-storage/async-storage": "^1.2.0"
   }
 }
diff --git a/packages/event-processor/src/reactNativeAsyncStorageCache.ts b/packages/event-processor/src/reactNativeAsyncStorageCache.ts
@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import AsyncStorage from '@react-native-community/async-storage';
+import AsyncStorage from '@react-native-async-storage/async-storage';
 
 import PersistentKeyValueCache from './persistentKeyValueCache';
 
