Send name of event tags instead of id (#39)

Author: onufryk

optimizely/event_builder.py

@@ -370,7 +370,7 @@ def _add_required_params_for_conversion(self, event_key, user_id, event_tags, va
           continue
 
         event_feature = {
-          'id': event_tag_id,
+          'name': event_tag_id,
           'type': 'custom',
           'value': event_tag_value,
           'shouldIndex': False,

tests/test_event_builder.py

@@ -406,12 +406,12 @@ def test_create_conversion_event__with_event_value(self):
         'value': 4200
       }],
       'eventFeatures': [{
-          'id': 'non-revenue',
+          'name': 'non-revenue',
           'type': 'custom',
           'value': 'abc',
           'shouldIndex': False,
         }, {
-          'id': 'revenue',
+          'name': 'revenue',
           'type': 'custom',
           'value': 4200,
           'shouldIndex': False,
@@ -448,7 +448,7 @@ def test_create_conversion_event__with_event_value(self):
       )
 
     # Sort event features based on ID
-    event_obj.params['eventFeatures'] = sorted(event_obj.params['eventFeatures'], key=lambda x: x.get('id'))
+    event_obj.params['eventFeatures'] = sorted(event_obj.params['eventFeatures'], key=lambda x: x.get('name'))
     self._validate_event_object(event_obj,
                                 event_builder.EventBuilderV2.CONVERSION_ENDPOINT,
                                 expected_params,
@@ -468,12 +468,12 @@ def test_create_conversion_event__with_invalid_event_value(self):
       'revision': '42',
       'eventMetrics': [],
       'eventFeatures': [{
-          'id': 'non-revenue',
+          'name': 'non-revenue',
           'type': 'custom',
           'value': 'abc',
           'shouldIndex': False,
         }, {
-          'id': 'revenue',
+          'name': 'revenue',
           'type': 'custom',
           'value': '4200',
           'shouldIndex': False,
@@ -508,7 +508,7 @@ def test_create_conversion_event__with_invalid_event_value(self):
         [self.project_config.get_experiment_from_key('test_experiment')]
       )
     # Sort event features based on ID
-    event_obj.params['eventFeatures'] = sorted(event_obj.params['eventFeatures'], key=lambda x: x.get('id'))
+    event_obj.params['eventFeatures'] = sorted(event_obj.params['eventFeatures'], key=lambda x: x.get('name'))
     self._validate_event_object(event_obj,
                                 event_builder.EventBuilderV2.CONVERSION_ENDPOINT,
                                 expected_params,

tests/test_optimizely.py

@@ -775,12 +775,12 @@ def test_track__with_event_value(self):
       'eventEntityId': '111095',
       'eventName': 'test_event',
       'eventFeatures': [{
-          'id': 'non-revenue',
+          'name': 'non-revenue',
           'type': 'custom',
           'value': 'abc',
           'shouldIndex': False,
         }, {
-          'id': 'revenue',
+          'name': 'revenue',
           'type': 'custom',
           'value': 4200,
           'shouldIndex': False,
@@ -807,7 +807,7 @@ def test_track__with_event_value(self):
 
     # Sort event features based on ID
     mock_dispatch_event.call_args[0][0].params['eventFeatures'] = sorted(
-      mock_dispatch_event.call_args[0][0].params['eventFeatures'], key=lambda x: x.get('id')
+      mock_dispatch_event.call_args[0][0].params['eventFeatures'], key=lambda x: x.get('name')
     )
     self._validate_event_object(mock_dispatch_event.call_args[0][0], 'https://logx.optimizely.com/log/event',
                                 expected_params, 'POST', {'Content-Type': 'application/json'})
@@ -839,7 +839,7 @@ def test_track__with_deprecated_event_value(self):
       'eventEntityId': '111095',
       'eventName': 'test_event',
       'eventFeatures': [{
-          'id': 'revenue',
+          'name': 'revenue',
           'type': 'custom',
           'value': 4200,
           'shouldIndex': False,
@@ -896,7 +896,7 @@ def test_track__with_invalid_event_value(self):
       'eventEntityId': '111095',
       'eventName': 'test_event',
       'eventFeatures': [{
-          'id': 'revenue',
+          'name': 'revenue',
           'type': 'custom',
           'value': '4200',
           'shouldIndex': False,