[FSSDK-12105] chore: inject cmab config to client #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iling slash sanitization in CmabClient and CmabConfig files
raju-opti
requested changes
Dec 1, 2025
Sources/CMAB/CmabConfig.swift
Outdated
|
|
||
| let DEFAULT_CMAB_CACHE_TIMEOUT = 30 * 60 // 30 minutes | ||
| let DEFAULT_CMAB_CACHE_SIZE = 100 | ||
| let CMAB_PREDICTION_END_POINT = "https://prediction.cmab.optimizely.com/predict" |
There was a problem hiding this comment.
we need to make this a template string with a placeholder for the ruleId (If the user is using a custom url, we cannot force them to have the ruleId at the end)
raju-opti
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues