[GR-63588] Add an entry to opt deopt log showing whether the compilation was invalidated.

PullRequest: graal/21824

Author: jchalou

sdk/CHANGELOG.md

@@ -5,6 +5,7 @@ This changelog summarizes major changes between GraalVM SDK versions. The main f
 ## Version 26.0.0
 * GR-65048: GR-65048: Introduced the `-Dpolyglot.engine.allowUnsupportedPlatform=true` system property to enable Truffle to run on unsupported platforms. If this property is enabled then the failure will be suppressed. Please see follow-up errors and warnings for instructions on how to continue. Note that using an unsupported platform will also force the fallback runtime without runtime optimization.
 * GR-66515 If neither a log handler nor the `log.file` option is set on the `Engine.Builder` or `Context.Builder`, Truffle and language log messages will be written to the Context’s error output stream by default. The `log.file` option is now also supported on `Context.Builder`.
+* GR-63588 A new entry (`Invalidated`) was added to the `opt deopt` truffle compilation logs. It is `true` or `false` depending on whether the compilation was also invalidated.
 
 ## Version 25.0.0
 * GR-60636 Truffle now stops compiling when the code cache fills up on HotSpot. A warning is printed when that happens.

truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/debug/JFRListener.java

@@ -122,6 +122,7 @@ public void onCompilationDeoptimized(OptimizedCallTarget target, Frame frame) {
         DeoptimizationEvent event = factory.createDeoptimizationEvent();
         if (event.isEnabled()) {
             event.setRootFunction(target);
+            event.setInvalidated(!target.isValid());
             event.publish();
         }
     }

truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/debug/TraceCompilationListener.java

@@ -100,9 +100,10 @@ public static void install(OptimizedTruffleRuntime runtime) {
     private static final String START_FORMAT    = "opt start  " + TARGET_FORMAT + "|" + TIER_FORMAT + "|Priority %9d|Rate %.6f|"         + QUEUE_FORMAT + "|UTC %s|Src %s|Bonuses %s";
     private static final String DONE_FORMAT     = "opt done   " + TARGET_FORMAT + "|" + TIER_FORMAT + "|Time %18s|AST %4d|Inlined %3dY %3dN|IR %6d/%6d|CodeSize %7d|Addr 0x%012x|CompId %-7s|UTC %s|Src %s";
     private static final String FAILED_FORMAT   = "opt failed " + TARGET_FORMAT + "|" + TIER_FORMAT + "|Time %18s|Reason: %s|UTC %s|Src %s";
-    private static final String PADDING         = "                                                                                                                              ";
-    private static final String INV_FORMAT      = "opt inval. " + TARGET_FORMAT + " " + PADDING + "|UTC %s|Src %s|Reason %s";
-    private static final String DEOPT_FORMAT    = "opt deopt  " + TARGET_FORMAT + "|" + PADDING + "|UTC %s|Src %s";
+    private static final String INV_PADDING     = "                                                                                                                              ";
+    private static final String DEOPT_PADDING   = "                                                                                                            ";
+    private static final String INV_FORMAT      = "opt inval. " + TARGET_FORMAT + " " + INV_PADDING + "|UTC %s|Src %s|Reason %s";
+    private static final String DEOPT_FORMAT    = "opt deopt  " + TARGET_FORMAT + "|Invalidated %5b|" + DEOPT_PADDING + "|UTC %s|Src %s";
     // @formatter:on
 
     @Override
@@ -228,6 +229,7 @@ public void onCompilationDeoptimized(OptimizedCallTarget target, Frame frame) {
                             target.engineId(),
                             target.id,
                             safeTargetName(target),
+                            !target.isValid(),
                             TIME_FORMATTER.format(ZonedDateTime.now()),
                             formatSourceSection(safeSourceSection(target))));
         }

truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/jfr/DeoptimizationEvent.java

@@ -41,4 +41,5 @@
 package com.oracle.truffle.runtime.jfr;
 
 public interface DeoptimizationEvent extends RootFunctionEvent {
+    void setInvalidated(boolean invalidated);
 }

truffle/src/com.oracle.truffle.runtime/src/com/oracle/truffle/runtime/jfr/impl/DeoptimizationEventImpl.java

@@ -55,4 +55,9 @@
 @StackTrace(false)
 class DeoptimizationEventImpl extends RootFunctionEventImpl implements DeoptimizationEvent {
 
+    @Label("Invalidated") @Description("Invalidated") public boolean invalidated;
+
+    public void setInvalidated(boolean invalidated) {
+        this.invalidated = invalidated;
+    }
 }