-
Notifications
You must be signed in to change notification settings - Fork 28
Description
Description
In this test module - https://github.com/oracle/macaron/blob/612e27ec347e7e073311b65a32b9eec8c6ba7d5c/tests/malware_analyzer/pypi/test_pypi_sourcecode_analyzer.py, we are mocking the defaults
object to test some behaviors relating to some source code analysis configuration in defaults.ini
.
Expectation
In this module https://github.com/oracle/macaron/blob/44dbf0acbd3dcb9f577db97b5c6876cfb8c87957/tests/config/test_defaults.py we put the defaults.ini content into a temporary file and load from it.
This is an example
macaron/tests/config/test_defaults.py
Lines 103 to 109 in 44dbf0a
user_config_path = os.path.join(tmp_path, "config.ini") | |
with open(user_config_path, "w", encoding="utf-8") as user_config_file: | |
user_config_file.write(user_config_input) | |
load_defaults(user_config_path) | |
results = defaults.get_list(section="test.list", option="list", delimiter=delimiter, strip=strip) | |
assert results == expect |
which can remove the need for mocking and keep the defaults.ini in the test definition itself. Perhaps we can rewrite the tests in test_pypi_sourcecode_analyzer.py
to use this approach instead.