Skip to content

Commit 573c02e

Browse files
removed the see details to the auth errors and change to dismiss into the auth warnings
1 parent d7a4ae1 commit 573c02e

File tree

4 files changed

+11
-2
lines changed

4 files changed

+11
-2
lines changed

packages/vscode-extension/messages.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
"BUTTONS_RESTART_NOW": "Restart Now",
1414
"BUTTONS_SEE_DETAILS": "See Details",
15+
"BUTTON_DISMISS": "Dismiss",
1516

1617
"COMMAND_ERROR": "Something went wrong with '{0}'.",
1718
"COMMAND_SUCCESS": "'{0}' has been successfully executed.",

packages/vscode-extension/src/commands/SetupAccount.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export default class SetupAccount extends BaseAction {
115115
try {
116116
validatorFunction();
117117
} catch (err: any) {
118-
this.messageService.showCommandError(err);
118+
this.messageService.showErrorMessage(err);
119119
return false;
120120
}
121121
return true;
@@ -205,7 +205,7 @@ export default class SetupAccount extends BaseAction {
205205

206206
const warning = ExecutionContextService.getBrowserBasedWarningMessages();
207207
if (warning) {
208-
this.messageService.showCommandWarning(warning);
208+
this.messageService.showWarningMessageDismiss(warning);
209209
}
210210
}
211211

packages/vscode-extension/src/service/MessageService.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,13 @@ export default class MessageService {
5252
);
5353
}
5454

55+
showWarningMessageDismiss(warningMessage: string, includeProjectName = true) {
56+
window.showWarningMessage(
57+
includeProjectName ? this.addProjectNameToMessage(warningMessage) : warningMessage,
58+
this.translationService.getMessage(BUTTONS.DISMISS),
59+
);
60+
}
61+
5562
showErrorMessage(errorMessage: string) {
5663
window.showErrorMessage(this.addProjectNameToMessage(errorMessage));
5764
}

packages/vscode-extension/src/service/TranslationKeys.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ export const ANSWERS = {
2222
export const BUTTONS = {
2323
RESTART_NOW: 'BUTTONS_RESTART_NOW',
2424
SEE_DETAILS: 'BUTTONS_SEE_DETAILS',
25+
DISMISS: 'BUTTON_DISMISS'
2526
};
2627

2728
export const COMMAND = {

0 commit comments

Comments
 (0)