Skip to content

Commit a8d5fac

Browse files
Last commit hopefully
1 parent e1a0cbe commit a8d5fac

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

packages/vscode-extension/messages.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@
6767
"DEVASSIST_SERVICE_FEEDBACK_FORM_FIELD_MUST_HAVE_BE_A_VALID_NUMBER": "Choose a natural number between {0} and {1}.",
6868
"DEVASSIST_SERVICE_FEEDBACK_FORM_FIELD_MUST_HAVE_SPECIFIC_VALUES": "Select any values from the ones available: {0}.",
6969
"DEVASSIST_SERVICE_FEEDBACK_FORM_SUBMITTING_ERROR_REAUTHORIZE_TOAST": "Error 403: {0}",
70-
"DEVASSIST_SERVICE_FEEDBACK_FORM_SUBMITTING_ERROR_TOAST": "Unable to connect to the SuiteCloud Developer Assistant service. Is it running?{0}",
70+
"DEVASSIST_SERVICE_FEEDBACK_FORM_SUBMITTING_ERROR_TOAST": "Unable to connect to the SuiteCloud Developer Assistant service. Is it running?",
7171
"DEVASSIST_SERVICE_FEEDBACK_FORM_SUBMITTING_EXTERNAL_ERROR": "A server error has occurred while submitting feedback for the SuiteCloud Developer Assistant (Error {0}: {1}).",
72-
"DEVASSIST_SERVICE_FEEDBACK_FORM_SUBMITTING_INTERNAL_ERROR": "There was a problem while submitting feedback for the SuiteCloud Developer Assistant. Is it running?",
72+
"DEVASSIST_SERVICE_FEEDBACK_FORM_SUBMITTING_INTERNAL_ERROR": "There was a problem while submitting feedback for the SuiteCloud Developer Assistant. Is it running?{0}",
7373
"DEVASSIST_SERVICE_FEEDBACK_FORM_SUBMIT_SUCCESS": "Your feedback for the SuiteCloud Developer Assistant was successfully submitted.",
7474

7575
"DEVASSIST_SERVICE_OUTPUT_PROXY_ERROR": "There was a problem while running SuiteCloud Developer Assistant service.\n{0}",

packages/vscode-extension/resources/media/FeedbackForm.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ <h1 id="title">SuiteCloud Developer Assistant Feedback</h1>
2121
<fieldset>
2222
<legend>This feedback is about</legend>
2323
<div class="checks">
24-
<label><input type="checkbox" name="topics" value="code-explanation">Code explanation</label>
25-
<label><input type="checkbox" name="topics" value="sdf-objects-generation">SDF custom objects generation </label>
26-
<label><input type="checkbox" name="topics" value="suitescript-code-generation">SuiteScript code generation</label>
27-
<label><input type="checkbox" name="topics" value="unit-testing">Unit testing</label>
28-
<label><input type="checkbox" name="topics" value="other">Other</label>
24+
<label><input type="checkbox" name="topics" value="CodeExplanation">Code explanation</label>
25+
<label><input type="checkbox" name="topics" value="SDFObjectGeneration">SDF custom objects generation </label>
26+
<label><input type="checkbox" name="topics" value="SuiteScriptCodeGeneration">SuiteScript code generation</label>
27+
<label><input type="checkbox" name="topics" value="UnitTesting">Unit testing</label>
28+
<label><input type="checkbox" name="topics" value="Other">Other</label>
2929
</div>
3030
</fieldset>
3131

packages/vscode-extension/src/webviews/FeedbackFormWebviewController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ const handleSubmitFeedbackFormEvent = async (formData : FeedbackFormData, cssWeb
158158
} catch (error) {
159159
// VSCODE ERROR, PROXY_NOT_LOADED, PROXY_ERROR, REQUEST_FORMATING_ERROR (Not even a response received)
160160
vsLogger.printTimestamp();
161-
vsLogger.error(translationService.getMessage(DEVASSIST_SERVICE.FEEDBACK_FORM.SUBMITTING_ERROR_TOAST, error ? '\n' + error : ''));
161+
vsLogger.error(translationService.getMessage(DEVASSIST_SERVICE.FEEDBACK_FORM.SUBMITTING_INTERNAL_ERROR, error ? '\n' + error : ''));
162162
vsLogger.error('');
163163

164164
// TODO: Find a way to not delete the user input when swaping HTML / clicking out

packages/vscode-extension/src/webviews/WebviewFieldValidationUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export const validateMultipleOptionField = (fieldName : string, selectedOptions
3838
translationService.getMessage(DEVASSIST_SERVICE.FEEDBACK_FORM.FIELD.CANNOT_HAVE_REPEATED_VALUES, selectedOptions.toString()));
3939
}
4040
for (const option of selectedOptions) {
41-
if (acceptableOptions.includes(option)) {
41+
if (!acceptableOptions.includes(option)) {
4242
return translationService.getMessage(DEVASSIST_SERVICE.FEEDBACK_FORM.FIELD.VALIDATION_ERROR,
4343
fieldName,
4444
translationService.getMessage(DEVASSIST_SERVICE.FEEDBACK_FORM.FIELD.MUST_HAVE_SPECIFIC_VALUES, acceptableOptions.toString()));

0 commit comments

Comments
 (0)