Merge pull request #884 from oracle/bugfix/PDPDEVTOOL-6004-VSCode-Remove-the-Option-authid-must-have-a-value-error-when-creating-new-project

davidecorreu · web-flow · commit db7bc2247fd6 · 2025-01-31T18:08:00.000+01:00
Bugfix/PDPDEVTOOL-6004: [vscode] Removed the "option --authid must have a value" error message when creating new project
diff --git a/packages/vscode-extension/src/commands/BaseAction.ts b/packages/vscode-extension/src/commands/BaseAction.ts
@@ -54,12 +54,11 @@ export default abstract class BaseAction {
 
 			if (this.commandMetadata.isSetupRequired) {
 				const defaultAuthId = this.getDefaultAuthId();
-				if (defaultAuthId !== '') {
-					await this.checkAndRefreshAuthorizationIfNeeded(defaultAuthId);
-				} else {
+				if (!defaultAuthId) {
 					showSetupAccountWarningMessage();
 					return;
 				}
+				await this.checkAndRefreshAuthorizationIfNeeded(defaultAuthId);
 			}
 
 			return this.execute();

Original file line number	Diff line number	Diff line change
`@@ -54,12 +54,11 @@ export default abstract class BaseAction {`
`54`	`54`
`55`	`55`	`if (this.commandMetadata.isSetupRequired) {`
`56`	`56`	`const defaultAuthId = this.getDefaultAuthId();`
`57`		`- if (defaultAuthId !== '') {`
`58`		`- await this.checkAndRefreshAuthorizationIfNeeded(defaultAuthId);`
`59`		`- } else {`
	`57`	`+ if (!defaultAuthId) {`
`60`	`58`	`showSetupAccountWarningMessage();`
`61`	`59`	`return;`
`62`	`60`	`}`
	`61`	`+ await this.checkAndRefreshAuthorizationIfNeeded(defaultAuthId);`
`63`	`62`	`}`
`64`	`63`
`65`	`64`	`return this.execute();`