Fixed an issue when durability is set to null or invalid value. (#29)

Added an unit test for the same

Testing: All unit tests passed

Author: Akshay-Sundarraj

src/main/java/com/oracle/nosql/spring/data/repository/NosqlRepository.java

@@ -157,6 +157,8 @@ public interface NosqlRepository<T, ID extends Serializable> extends
      * {@link Durability#COMMIT_SYNC}.<p>
      * This set takes precedence over the one set when using
      * {@link NosqlTable#durability()}.<p>
+     * If null or invalid value is provided durability will be set to
+     * {@link Durability#COMMIT_NO_SYNC}<p>
      * Note: This applies to On-Prem installations only.
      */
     void setDurability(String durability);

src/main/java/com/oracle/nosql/spring/data/repository/support/NosqlEntityInformation.java

@@ -304,12 +304,16 @@ private void setTableOptions(Class<T> domainClass) {
     }
 
     private Durability getDurability(String durability) {
+        if (durability == null) {
+            return Durability.COMMIT_NO_SYNC;
+        }
         if ("COMMIT_SYNC".equals(durability.toUpperCase())) {
             return Durability.COMMIT_SYNC;
         }
         if ("COMMIT_WRITE_NO_SYNC".equals(durability.toUpperCase())) {
             return Durability.COMMIT_WRITE_NO_SYNC;
         }
+        //return COMMIT_NO_SYNC by default
         return Durability.COMMIT_NO_SYNC;
     }
 

src/main/java/com/oracle/nosql/spring/data/repository/support/SimpleNosqlRepository.java

@@ -256,17 +256,14 @@ public String getDurability() {
     }
 
     static String convertDurability(Durability durability) {
-        if (durability == Durability.COMMIT_NO_SYNC) {
-            return "COMMIT_NO_SYNC";
-        }
-        if (durability == Durability.COMMIT_SYNC) {
+        if (Durability.COMMIT_SYNC.equals(durability)) {
             return "COMMIT_SYNC";
         }
-        if (durability == Durability.COMMIT_WRITE_NO_SYNC) {
+        if (Durability.COMMIT_WRITE_NO_SYNC.equals(durability)) {
             return "COMMIT_WRITE_NO_SYNC";
         }
 
-        return durability.toString();
+        return "COMMIT_NO_SYNC";
     }
 
     /**

src/test/java/com/oracle/nosql/spring/data/test/TestApplication.java

@@ -465,6 +465,14 @@ public void testConsistencyDurability() {
         repo.setDurability("COMMIT_WRITE_NO_SYNC");
         Assert.assertEquals("COMMIT_WRITE_NO_SYNC",
             repo.getDurability());
+
+        //null durability
+        repo.setDurability(null);
+        Assert.assertEquals("COMMIT_NO_SYNC", repo.getDurability());
+
+        //invalid durability
+        repo.setDurability("INVALID");
+        Assert.assertEquals("COMMIT_NO_SYNC", repo.getDurability());
     }
 
     @SuppressWarnings("unchecked")
@@ -666,4 +674,4 @@ private void printWithTypes(String name, Map<?, ?> map) {
             }
         }
     }
-}
+}