Fix bug when detecting in-band notification warning while connection is

being created or actively used (#383).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -11,6 +11,17 @@ Release changes are listed as affecting Thin Mode (the default runtime behavior
 of python-oracledb), as affecting the optional :ref:`Thick Mode
 <enablingthick>`, or as being 'Common' for changes that impact both modes.
 
+oracledb 2.4.1 (August 2024)
+----------------------------
+
+Thin Mode Changes
++++++++++++++++++
+
+#)  Fixed bug when detecting in-band notification warnings while the connection
+    is being created or actively used
+    (`issue 383 <https://github.com/oracle/python-oracledb/issues/383>`__).
+
+
 oracledb 2.4.0 (August 2024)
 ----------------------------
 

src/oracledb/impl/thin/packet.pyx

@@ -219,7 +219,9 @@ cdef class ReadBuffer(Buffer):
         Checks to see if the transport is connected and throws the appropriate
         exception if not.
         """
-        if self._pending_error_num != 0:
+        if self._pending_error_num not in (
+            0, TNS_ERR_SESSION_SHUTDOWN, TNS_ERR_INBAND_MESSAGE
+        ):
             if self._transport is not None:
                 self._transport.disconnect()
                 self._transport = None

src/oracledb/impl/thin/pool.pyx

@@ -853,7 +853,7 @@ cdef class PooledConnRequest:
                 buf.check_control_packet()
         if buf._pending_error_num != 0:
             self.pool_impl._drop_conn_impl(conn_impl)
-            self._open_count -= 1
+            self.pool_impl._open_count -= 1
         else:
             self.conn_impl = conn_impl
             if self.pool_impl._ping_interval == 0:

src/oracledb/version.py

@@ -30,4 +30,4 @@
 # file doc/src/conf.py both reference this file directly.
 # -----------------------------------------------------------------------------
 
-__version__ = "2.4.0"
+__version__ = "2.4.1"