The error "DPY-3015: password verifier type is not supported by

python-oracledb in thin mode" is now raised when the database sends a
password challenge with a verifier type that is not recognized, instead
of "ORA-01017: invalid username/password" (#26).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -13,6 +13,12 @@ oracledb 1.0.3 (August 2022)
 Thin Mode Changes
 +++++++++++++++++
 
+#)  The error `DPY-3015: password verifier type is not supported by
+    python-oracledb in thin mode` is now raised when
+    the database sends a password challenge with a verifier type that is not
+    recognized, instead of `ORA-01017: invalid username/password`
+    (`issue 26 <https://github.com/oracle/python-oracledb/issues/26>`__).
+
 Common Changes
 ++++++++++++++
 

src/oracledb/errors.py

@@ -170,6 +170,7 @@ def _raise_from_string(exc_type: Exception, message: str) -> None:
 ERR_NCHAR_CS_NOT_SUPPORTED = 3012
 ERR_UNSUPPORTED_PYTHON_TYPE_FOR_VAR = 3013
 ERR_LOB_OF_WRONG_TYPE = 3014
+ERR_UNSUPPORTED_VERIFIER_TYPE = 3015
 
 # error numbers that result in DatabaseError
 ERR_TNS_ENTRY_NOT_FOUND = 4000
@@ -434,6 +435,9 @@ def _raise_from_string(exc_type: Exception, message: str) -> None:
             '{db_type_name}',
     ERR_UNSUPPORTED_VAR_SET:
             'variable of type {db_type_name} does not support being set',
+    ERR_UNSUPPORTED_VERIFIER_TYPE:
+            'password verifier type 0x{verifier_type:x} is not supported by '
+            'python-oracledb in thin mode',
     ERR_WALLET_FILE_MISSING:
             'cannot connect to database. Wallet file {name} was not found',
     ERR_WRONG_ARRAY_DEFINITION:

src/oracledb/impl/thin/constants.pxi

@@ -596,8 +596,9 @@ DEF TNS_RCAP_TTC_ZERO_COPY = 0x01
 DEF TNS_RCAP_TTC_32K = 0x04
 
 # verifier types
-DEF TNS_VERIFIER_TYPE_SHA1 = 45394
-DEF TNS_VERIFIER_TYPE_SSHA1 = 6949
+DEF TNS_VERIFIER_TYPE_11G_1 = 0xb152
+DEF TNS_VERIFIER_TYPE_11G_2 = 0x1b25
+DEF TNS_VERIFIER_TYPE_12C = 0x4815
 
 # other constants
 DEF TNS_MAX_SHORT_LENGTH = 252

src/oracledb/impl/thin/messages.pyx

@@ -1477,9 +1477,13 @@ cdef class AuthMessage(Message):
             if self.purity != 0:
                 num_pairs += 1
             self.auth_mode |= TNS_AUTH_MODE_WITH_PASSWORD
-            if self.verifier_type == TNS_VERIFIER_TYPE_SHA1 \
-                    or self.verifier_type == TNS_VERIFIER_TYPE_SSHA1:
+
+            if self.verifier_type in (TNS_VERIFIER_TYPE_11G_1,
+                                      TNS_VERIFIER_TYPE_11G_2):
                 verifier_11g = True
+            elif self.verifier_type != TNS_VERIFIER_TYPE_12C:
+                errors._raise_err(errors.ERR_UNSUPPORTED_VERIFIER_TYPE,
+                                  verifier_type=self.verifier_type)
             else:
                 num_pairs += 1
             self._generate_verifier(verifier_11g)