Skip to content

Use ipfs-core-types; Updated npm git dependency format; Minor fixes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use ipfs-core-types; Updated npm git dependency format; Minor fixes #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb0e98d
Use ipfs-core-types; Minor type fixes
ple1n Mar 20, 2022
6b62202
ipfs-core-types; npm dep format; minor type fixes
ple1n Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions OrbitDB.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ declare module 'orbit-db' {
import EventStore from "orbit-db-eventstore";
import DocumentStore from "orbit-db-docstore";
import CounterStore from "orbit-db-counterstore";
import { Keystore } from "orbit-db-keystore";
import {Keystore} from "orbit-db-keystore";
import Cache from "orbit-db-cache";
import { Identity } from "orbit-db-identity-provider";
import * as IPFS from "ipfs";
import {Identity} from "orbit-db-identity-provider";
import {IPFS} from "ipfs-core-types";
import * as elliptic from "elliptic";
import OrbitDBAddress from 'orbit-db'
export class OrbitDB {
Expand All @@ -21,12 +21,12 @@ declare module 'orbit-db' {
stores: any;
directory: string;
keystore: Keystore;

// For OpenTelemetry Plugin
span?: any;

static databaseTypes: string[];


constructor(ipfs: IPFS, directory?: string, options?: {
peerId?: string,
Expand Down
1 change: 1 addition & 0 deletions OrbitDBAccessControllers/AccessControllerInterface.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ declare module "orbit-db-access-controllers/src/access-controller-interface" {

import OrbitDB from 'orbit-db'
import { IdentityProvider } from 'orbit-db-identity-provider'
import { EventEmitter } from 'events'


/**
Expand Down
4 changes: 2 additions & 2 deletions Store.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
declare module "orbit-db-store" {
import IPFS = require("ipfs");
import { IPFS } from "ipfs-core-types";
import { Identity } from "orbit-db-identity-provider";
import { EventEmitter } from 'events';
import * as elliptic from "elliptic";
Expand All @@ -15,7 +15,7 @@ declare module "orbit-db-store" {
/**
* Contains all entries of this Store
*/
all: any[];
all: any[] | {};
Copy link
Member

@tabcat tabcat Mar 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should only be any[]

https://github.com/orbitdb/orbit-db-store/blob/6a450aca4ba7f5a041677f5cf25632f0170cf7b7/src/Store.js#L155

Copy link
Author

@ple1n ple1n Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be, but the IDE told me it could be {} too, for some reason. uh, right, the implementation should be changed instead

Copy link
Member

@tabcat tabcat Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think the code block I linked needs to be changed, and im not sure how it could return an object.

Copy link
Author

@ple1n ple1n Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it shouldn't be. If for some reason it returns an object it's the fault of orbit-db not its typing.

type: string;
/**
* Returns an instance of `elliptic.ec.KeyPair`.
Expand Down
Loading