Contribute updates back to ScanCode?

[pombredanne]

Hi:
First thank you for using ScanCode!
In your readme you wrote:

scancode-tookit is licensed under Apache-2.0.(We added and modified some detection rules.)

It would be awesome if you want to contribute these detection rules additions and modification .)
In particular your help would be much welcomed to add http://license.coscl.org.cn/MulanPubL-2.0/ (Both Chinese and English version)

We only have the PSL for now as you can see in https://scancode-licensedb.aboutcode.org/?search=Mulan

Thank you for your kind consideration!

[zhcxww]

That's no problem! I will submit a PR soon 😄

[minghuizhou]

Is this still a case? @zhcxww how is the progress? May we make a contribution to scancode?

[zhcxww]

@minghuizhou Not yet 😅 — all licenses in the Mulan family (e.g., MulanPSL-1.0/2.0, MulanPubL-2.0) should be contributed to ScanCode.
This can actually be a nice task for students in the open source development course, they can help add the detection rules and test samples. I can help with their PRs.

[pombredanne]

@zhcxww I would welcome the help and can help the students too.

Note that since this issue was filed, we have added the English versions of more Mulan licenses as you can see here:

• https://github.com/search?q=repo%3Aaboutcode-org%2Fscancode-toolkit+mulan+path%3Asrc%2Flicensedcode%2Fdata%2Flicenses%2F&type=code

What we do not have are:

• the Chinese versions of the license texts.
• Chinese and English common notice texts as seen in the wild for each of these licenses.

And also:

• proper license detection support for Chinese texts, with correct word segmentation in each of the techniques used, and may be more, new techniques

@minghuizhou hello 👋

[Tang-Kin-Long]

Hello, I am working on this issue. Firstly, I will add the Mulan family into the text and rule base of ScanCode. @pombredanne @minghuizhou @zhcxww

[Tang-Kin-Long]

I've done some tests in local environment to show that existing rules for Mulan PSL v1, ,Mulan PSL v2, Mulan PubL v2 can adequately detect and distinguish Mulan license. And currently I only consider to add a new rule mulanpubl-1.0_1.RULE for Mulan PubL v1, which takes the content of mulanpubl-2.0_1.RULE as reference.
I've submitted PR in scancode project and passed submission tests 😊 @pombredanne

[minghuizhou]

@Tang-Kin-Long how about the rule for MulanPSL?

[Tang-Kin-Long]

@minghuizhou I have conducted some tests as far as possible and verified that current rules for MulanPSL can fully detect the cases. Adding some extra rules could be considered of course, but for now I think it seems a bit redundant😅