Skip to content

Commit 492548a

Browse files
committed
properly bound the catch for TypeError to stop hiding bugs
1 parent 3b725d1 commit 492548a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

buildbot/master/master.cfg

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,6 @@ def builder(**configExtra):
329329
def runstep(step):
330330
try:
331331
steps = iter(step)
332-
for step in steps:
333-
runstep(step)
334332
except TypeError:
335333
info = step._factory
336334
stepkwargs = dict(
@@ -339,6 +337,9 @@ def builder(**configExtra):
339337
stepkwargs.update(info.kwargs)
340338
step = info.factory(*info.args, **stepkwargs)
341339
factory.addStep(step)
340+
return
341+
for step in steps:
342+
runstep(step)
342343

343344
runstep(f())
344345

0 commit comments

Comments
 (0)