Upload via share link from the gallery view

[jancborchardt]

Similar to #25 (upload straight from the app) but in the share link view.

Use-case: I often share picture folders with friends who also made photos from the same event. Since I want them to add their photos too, I send them the normal share link because there the upload button shows. But it’s the lame list view – I’d much rather have them see the pictures in the nice photo layout, but also be able to add their photos.

@oparoz I assume this is blocked by core just like #25? What is necessary to make it work? Can you maybe even submit a pull request for it?

TODO

• Upload straight from the app Upload straight from the app [$250] #25
• Add missing options to the share dialogue Add the checkbox in the share dialogue to allow uploading from the public side #565
• Fix OC9: public share with allowed upload and password protection: endlees loading loop core#23066 via PR Fix of issue #23066 #652

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[oparoz]

The problem is that the upload mechanism is a dated hack, made of strings and which is not in the public space, so using it as-is a recipe for a maintenance nightmare imho. It also violates some oC rules which stipulate we should not create inter-app dependencies.

[jancborchardt]

Ok, then we need to reimplement the upload in Gallery to fix this? Or can we safely assume Files is always the base? At least Gallery does not make any sense without Files as base. cc @DeepDiver1975

[oparoz]

That's what we need:
owncloud/core#17610
but it's in the backlog.

The whole IE compatibility requirement also makes it difficult to introduce new features in official apps via HTML5 classes.

I'd say we should keep this on standby for when Gallery becomes official, because like you said Files is a crucial part of core and it wouldn't be a big deal for an official app to use its scripts if this requirement rises to the top of the queue.

[oparoz]

@karlitschek - Can we make this an HTML5, modern browser only feature? I think it's a nice-to-have feature, not a hard requirement, just like upload works differently in Files, depending on the browser used.

[karlitschek]

@MTRichards what do you think?

[MTRichards]

Ok for me if the coolest new stuff only works with a new browser, as long as the IE8 view is not totally mashed, just has to be performed in a different way.

[oparoz]

OK, thanks. It's not for right now anyway, but if I stumble upon a simple way to easily upload a bunch of images to the current folder without loading a large library, it's probably going to be for modern browsers only. I'll know more when I start looking.

[karlitschek]

good discussion guys :-)

[jancborchardt]

Yeah – if IE is a blocker for such a major feature, I’d say it’s fine to have it just for the modern browsers. If you only use IE, you will miss nothing.