Fix DI

bemusementpark · bemusementpark · commit 07c8ce47171a · 2023-05-17T11:13:34.000+09:30
diff --git a/app/src/main/java/org/thoughtcrime/securesms/MediaPreviewActivity.java b/app/src/main/java/org/thoughtcrime/securesms/MediaPreviewActivity.java
@@ -81,7 +81,6 @@
 import org.thoughtcrime.securesms.util.SaveAttachmentTask.Attachment;
 
 import java.io.IOException;
-import java.util.Locale;
 import java.util.WeakHashMap;
 
 import network.loki.messenger.R;
@@ -242,7 +241,7 @@ private void updateActionBar() {
       CharSequence relativeTimeSpan;
 
       if (mediaItem.date > 0) {
-        relativeTimeSpan = dateUtil.getDisplayFormattedTimeSpanString(mediaItem.date);
+        relativeTimeSpan = dateUtil.format(mediaItem.date);
       } else {
         relativeTimeSpan = getString(R.string.MediaPreviewActivity_draft);
       }
diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationActivityV2.kt
@@ -1728,7 +1728,7 @@ class ConversationActivityV2 : PassphraseRequiredActionBarActivity(), InputBarDe
             val body = MentionUtilities.highlightMentions(message.body, viewModel.threadId, this)
             if (TextUtils.isEmpty(body)) { continue }
             if (messageSize > 1) {
-                val formattedTimestamp = dateUtil.getDisplayFormattedTimeSpanString(message.timestamp)
+                val formattedTimestamp = dateUtil.format(message.timestamp)
                 builder.append("$formattedTimestamp: ")
             }
             builder.append(body)
diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationReactionOverlay.java b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/ConversationReactionOverlay.java
@@ -172,7 +172,7 @@ public void show(@NonNull Activity activity,
     conversationBubble.setLayoutParams(new LinearLayout.LayoutParams(conversationItemSnapshot.getWidth(), conversationItemSnapshot.getHeight()));
     conversationBubble.setBackground(new BitmapDrawable(getResources(), conversationItemSnapshot));
     TextView conversationTimestamp = conversationItem.findViewById(R.id.conversation_item_timestamp);
-    conversationTimestamp.setText(dateUtil.getDisplayFormattedTimeSpanString(messageRecord.getTimestamp()));
+    conversationTimestamp.setText(dateUtil.format(messageRecord.getTimestamp()));
 
     updateConversationTimestamp(messageRecord);
 
diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/ControlMessageView.kt b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/ControlMessageView.kt
@@ -7,12 +7,18 @@ import android.view.View
 import android.widget.LinearLayout
 import androidx.core.content.res.ResourcesCompat
 import androidx.recyclerview.widget.RecyclerView
+import dagger.hilt.android.AndroidEntryPoint
 import network.loki.messenger.R
 import network.loki.messenger.databinding.ViewControlMessageBinding
 import org.thoughtcrime.securesms.database.model.MessageRecord
+import org.thoughtcrime.securesms.util.DateUtil
+import javax.inject.Inject
 
+@AndroidEntryPoint
 class ControlMessageView : LinearLayout {
 
+    @Inject lateinit var dateUtil: DateUtil
+
     private lateinit var binding: ViewControlMessageBinding
 
     // region Lifecycle
@@ -28,7 +34,7 @@ class ControlMessageView : LinearLayout {
 
     // region Updating
     fun bind(message: MessageRecord, previous: MessageRecord?) {
-        binding.dateBreakTextView.showDateBreak(message, previous)
+        binding.dateBreakTextView.showDateBreak(dateUtil, message, previous)
         binding.iconImageView.visibility = View.GONE
         var messageBody: CharSequence = message.getDisplayBody(context)
         binding.root.contentDescription= null
diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/MessageUtilities.kt b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/MessageUtilities.kt
@@ -4,13 +4,11 @@ import android.widget.TextView
 import androidx.core.view.isVisible
 import org.thoughtcrime.securesms.database.model.MessageRecord
 import org.thoughtcrime.securesms.util.DateUtil
-import org.thoughtcrime.securesms.util.DateUtils
-import java.util.Locale
 
 private const val maxTimeBetweenBreaks = 5 * 60 * 1000L // 5 minutes
 
-fun TextView.showDateBreak(message: MessageRecord, previous: MessageRecord?) {
+fun TextView.showDateBreak(dateUtil: DateUtil, message: MessageRecord, previous: MessageRecord?) {
     val showDateBreak = (previous == null || message.timestamp - previous.timestamp > maxTimeBetweenBreaks)
     isVisible = showDateBreak
-    text = if (showDateBreak) DateUtil(context).getDisplayFormattedTimeSpanString(message.timestamp) else ""
+    text = if (showDateBreak) dateUtil.format(message.timestamp) else ""
 }
diff --git a/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt b/app/src/main/java/org/thoughtcrime/securesms/conversation/v2/messages/VisibleMessageView.kt
@@ -49,7 +49,6 @@ import org.thoughtcrime.securesms.home.UserDetailsBottomSheet
 import org.thoughtcrime.securesms.mms.GlideRequests
 import org.thoughtcrime.securesms.util.*
 import java.util.Date
-import java.util.Locale
 import javax.inject.Inject
 import kotlin.math.abs
 import kotlin.math.min
@@ -191,7 +190,7 @@ class VisibleMessageView : LinearLayout {
         binding.senderNameTextView.text = contact?.displayName(contactContext) ?: senderSessionID
         // Date break
         val showDateBreak = isStartOfMessageCluster || snIsSelected
-        binding.dateBreakTextView.text = if (showDateBreak) dateUtil.getDisplayFormattedTimeSpanString(message.timestamp) else null
+        binding.dateBreakTextView.text = if (showDateBreak) dateUtil.format(message.timestamp) else null
         binding.dateBreakTextView.isVisible = showDateBreak
         // Message status indicator
         if (message.isOutgoing) {
diff --git a/app/src/main/java/org/thoughtcrime/securesms/dependencies/AppModule.kt b/app/src/main/java/org/thoughtcrime/securesms/dependencies/AppModule.kt
@@ -8,6 +8,8 @@ import org.session.libsession.utilities.AppTextSecurePreferences
 import org.session.libsession.utilities.TextSecurePreferences
 import org.thoughtcrime.securesms.repository.ConversationRepository
 import org.thoughtcrime.securesms.repository.DefaultConversationRepository
+import org.thoughtcrime.securesms.util.AndroidClock
+import org.thoughtcrime.securesms.util.Clock
 
 @Module
 @InstallIn(SingletonComponent::class)
@@ -19,4 +21,7 @@ abstract class AppModule {
     @Binds
     abstract fun bindConversationRepository(repository: DefaultConversationRepository): ConversationRepository
 
+    @Binds
+    abstract fun bindAndroidClock(androidClock: AndroidClock): Clock
+
 }
diff --git a/app/src/main/java/org/thoughtcrime/securesms/home/ConversationView.kt b/app/src/main/java/org/thoughtcrime/securesms/home/ConversationView.kt
@@ -6,7 +6,6 @@ import android.graphics.Typeface
 import android.graphics.drawable.ColorDrawable
 import android.util.AttributeSet
 import android.util.TypedValue
-import android.view.LayoutInflater
 import android.view.View
 import android.widget.LinearLayout
 import androidx.core.content.ContextCompat
@@ -21,9 +20,7 @@ import org.thoughtcrime.securesms.database.RecipientDatabase.NOTIFY_TYPE_NONE
 import org.thoughtcrime.securesms.database.model.ThreadRecord
 import org.thoughtcrime.securesms.mms.GlideRequests
 import org.thoughtcrime.securesms.util.DateUtil
-import org.thoughtcrime.securesms.util.DateUtils
 import org.thoughtcrime.securesms.util.getAccentColor
-import java.util.Locale
 import javax.inject.Inject
 
 class ConversationView : LinearLayout {
@@ -89,7 +86,7 @@ class ConversationView : LinearLayout {
         val senderDisplayName = getUserDisplayName(thread.recipient)
                 ?: thread.recipient.address.toString()
         binding.conversationViewDisplayNameTextView.text = senderDisplayName
-        binding.timestampTextView.text = dateUtil.getDisplayFormattedTimeSpanString(thread.date)
+        binding.timestampTextView.text = dateUtil.format(thread.date)
         val recipient = thread.recipient
         binding.muteIndicatorImageView.isVisible = recipient.isMuted || recipient.notifyType != NOTIFY_TYPE_ALL
         val drawableRes = if (recipient.isMuted || recipient.notifyType == NOTIFY_TYPE_NONE) {
diff --git a/app/src/main/java/org/thoughtcrime/securesms/home/HomeActivity.kt b/app/src/main/java/org/thoughtcrime/securesms/home/HomeActivity.kt
@@ -65,7 +65,6 @@ import org.thoughtcrime.securesms.onboarding.SeedReminderViewDelegate
 import org.thoughtcrime.securesms.preferences.SettingsActivity
 import org.thoughtcrime.securesms.util.*
 import java.io.IOException
-import java.util.Locale
 import javax.inject.Inject
 
 @AndroidEntryPoint
@@ -95,7 +94,7 @@ class HomeActivity : PassphraseRequiredActionBarActivity(),
         HomeAdapter(context = this, listener = this)
     }
 
-    private val globalSearchAdapter = GlobalSearchAdapter { model ->
+    private val globalSearchAdapter = GlobalSearchAdapter(dateUtil) { model ->
         when (model) {
             is GlobalSearchAdapter.Model.Message -> {
                 val threadId = model.messageResult.threadId
@@ -285,7 +284,7 @@ class HomeActivity : PassphraseRequiredActionBarActivity(),
         if (messageRequestCount > 0 && !textSecurePreferences.hasHiddenMessageRequests()) {
             with(ViewMessageRequestBannerBinding.inflate(layoutInflater)) {
                 unreadCountTextView.text = messageRequestCount.toString()
-                timestampTextView.text = dateUtil.getDisplayFormattedTimeSpanString(threadDb.latestUnapprovedConversationTimestamp)
+                timestampTextView.text = dateUtil.format(threadDb.latestUnapprovedConversationTimestamp)
                 root.setOnClickListener { showMessageRequests() }
                 root.setOnLongClickListener { hideMessageRequests(); true }
                 root.layoutParams = RecyclerView.LayoutParams(RecyclerView.LayoutParams.MATCH_PARENT, RecyclerView.LayoutParams.WRAP_CONTENT)
diff --git a/app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchAdapter.kt b/app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchAdapter.kt
@@ -6,17 +6,22 @@ import android.view.ViewGroup
 import androidx.annotation.StringRes
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.RecyclerView
+import dagger.hilt.android.AndroidEntryPoint
 import network.loki.messenger.R
 import network.loki.messenger.databinding.ViewGlobalSearchHeaderBinding
 import network.loki.messenger.databinding.ViewGlobalSearchResultBinding
 import org.session.libsession.utilities.GroupRecord
 import org.session.libsession.utilities.recipients.Recipient
 import org.thoughtcrime.securesms.mms.GlideApp
 import org.thoughtcrime.securesms.search.model.MessageResult
+import org.thoughtcrime.securesms.util.DateUtil
 import java.security.InvalidParameterException
 import org.session.libsession.messaging.contacts.Contact as ContactModel
 
-class GlobalSearchAdapter (private val modelCallback: (Model)->Unit): RecyclerView.Adapter<RecyclerView.ViewHolder>() {
+class GlobalSearchAdapter(
+    private val dateUtil: DateUtil,
+    private val modelCallback: (Model) -> Unit
+) : RecyclerView.Adapter<RecyclerView.ViewHolder>() {
 
     companion object {
         const val HEADER_VIEW_TYPE = 0
@@ -47,8 +52,10 @@ class GlobalSearchAdapter (private val modelCallback: (Model)->Unit): RecyclerVi
         } else {
             ContentView(
                 LayoutInflater.from(parent.context)
-                    .inflate(R.layout.view_global_search_result, parent, false)
-            , modelCallback)
+                    .inflate(R.layout.view_global_search_result, parent, false),
+                dateUtil,
+                modelCallback
+            )
         }
 
     override fun onBindViewHolder(
@@ -69,7 +76,7 @@ class GlobalSearchAdapter (private val modelCallback: (Model)->Unit): RecyclerVi
     }
 
     override fun onBindViewHolder(holder: RecyclerView.ViewHolder, position: Int) {
-        onBindViewHolder(holder,position, mutableListOf())
+        onBindViewHolder(holder, position, mutableListOf())
     }
 
     class HeaderView(view: View) : RecyclerView.ViewHolder(view) {
@@ -87,8 +94,11 @@ class GlobalSearchAdapter (private val modelCallback: (Model)->Unit): RecyclerVi
         }
     }
 
-    class ContentView(view: View, private val modelCallback: (Model) -> Unit) : RecyclerView.ViewHolder(view) {
-
+    class ContentView(
+        view: View,
+        private val dateUtil: DateUtil,
+        private val modelCallback: (Model) -> Unit
+    ) : RecyclerView.ViewHolder(view) {
         val binding = ViewGlobalSearchResultBinding.bind(view).apply {
             searchResultProfilePicture.root.glide = GlideApp.with(root)
         }
@@ -102,7 +112,7 @@ class GlobalSearchAdapter (private val modelCallback: (Model)->Unit): RecyclerVi
             when (model) {
                 is Model.GroupConversation -> bindModel(query, model)
                 is Model.Contact -> bindModel(query, model)
-                is Model.Message -> bindModel(query, model)
+                is Model.Message -> bindModel(dateUtil, query, model)
                 is Model.SavedMessages -> bindModel(model)
                 is Model.Header -> throw InvalidParameterException("Can't display Model.Header as ContentView")
             }
@@ -112,14 +122,14 @@ class GlobalSearchAdapter (private val modelCallback: (Model)->Unit): RecyclerVi
     }
 
     data class MessageModel(
-            val threadRecipient: Recipient,
-            val messageRecipient: Recipient,
-            val messageSnippet: String
+        val threadRecipient: Recipient,
+        val messageRecipient: Recipient,
+        val messageSnippet: String
     )
 
     sealed class Model {
         data class Header(@StringRes val title: Int) : Model()
-        data class SavedMessages(val currentUserPublicKey: String): Model()
+        data class SavedMessages(val currentUserPublicKey: String) : Model()
         data class Contact(val contact: ContactModel) : Model()
         data class GroupConversation(val groupRecord: GroupRecord) : Model()
         data class Message(val messageResult: MessageResult, val unread: Int) : Model()
diff --git a/app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchAdapterUtils.kt b/app/src/main/java/org/thoughtcrime/securesms/home/search/GlobalSearchAdapterUtils.kt
@@ -15,7 +15,6 @@ import org.thoughtcrime.securesms.home.search.GlobalSearchAdapter.Model.GroupCon
 import org.thoughtcrime.securesms.home.search.GlobalSearchAdapter.Model.Message
 import org.thoughtcrime.securesms.home.search.GlobalSearchAdapter.Model.SavedMessages
 import org.thoughtcrime.securesms.util.DateUtil
-import org.thoughtcrime.securesms.util.DateUtils
 import org.thoughtcrime.securesms.util.SearchUtil
 import java.util.Locale
 import org.thoughtcrime.securesms.home.search.GlobalSearchAdapter.Model.Contact as ContactModel
@@ -126,7 +125,7 @@ fun ContentView.bindModel(model: SavedMessages) {
     binding.searchResultSavedMessages.isVisible = true
 }
 
-fun ContentView.bindModel(query: String?, model: Message) {
+fun ContentView.bindModel(dateUtil: DateUtil, query: String?, model: Message) {
     binding.searchResultProfilePicture.root.isVisible = true
     binding.searchResultSavedMessages.isVisible = false
     binding.searchResultTimestamp.isVisible = true
@@ -135,7 +134,7 @@ fun ContentView.bindModel(query: String?, model: Message) {
 //    if (hasUnreads) {
 //        binding.unreadCountTextView.text = model.unread.toString()
 //    }
-    binding.searchResultTimestamp.text = DateUtil(binding.root.context).getDisplayFormattedTimeSpanString(model.messageResult.sentTimestampMs)
+    binding.searchResultTimestamp.text = dateUtil.format(model.messageResult.sentTimestampMs)
     binding.searchResultProfilePicture.root.update(model.messageResult.conversationRecipient)
     val textSpannable = SpannableStringBuilder()
     if (model.messageResult.conversationRecipient != model.messageResult.messageRecipient) {
diff --git a/app/src/main/java/org/thoughtcrime/securesms/messagerequests/MessageRequestView.kt b/app/src/main/java/org/thoughtcrime/securesms/messagerequests/MessageRequestView.kt
@@ -14,8 +14,6 @@ import org.thoughtcrime.securesms.conversation.v2.utilities.MentionUtilities.hig
 import org.thoughtcrime.securesms.database.model.ThreadRecord
 import org.thoughtcrime.securesms.mms.GlideRequests
 import org.thoughtcrime.securesms.util.DateUtil
-import org.thoughtcrime.securesms.util.DateUtils
-import java.util.Locale
 
 @AndroidEntryPoint
 class MessageRequestView : LinearLayout {
@@ -43,7 +41,7 @@ class MessageRequestView : LinearLayout {
         val senderDisplayName = getUserDisplayName(thread.recipient)
             ?: thread.recipient.address.toString()
         binding.displayNameTextView.text = senderDisplayName
-        binding.timestampTextView.text = dateUtil.getDisplayFormattedTimeSpanString(thread.date)
+        binding.timestampTextView.text = dateUtil.format(thread.date)
         val rawSnippet = thread.getDisplayBody(context)
         val snippet = highlightMentions(rawSnippet, thread.threadId, context)
         binding.snippetTextView.text = snippet
diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/Clock.kt b/app/src/main/java/org/thoughtcrime/securesms/util/Clock.kt
@@ -1,10 +1,14 @@
 package org.thoughtcrime.securesms.util
 
+import javax.inject.Inject
+import javax.inject.Singleton
+
 interface Clock {
     val currentTimeMillis: Long
 }
 
-object AndroidClock: Clock {
+@Singleton
+class AndroidClock @Inject constructor(): Clock {
     override val currentTimeMillis: Long
         get() = System.currentTimeMillis()
 }
diff --git a/app/src/main/java/org/thoughtcrime/securesms/util/DateUtil.kt b/app/src/main/java/org/thoughtcrime/securesms/util/DateUtil.kt
@@ -7,13 +7,13 @@ import org.thoughtcrime.securesms.util.DateUtils.isSameDay
 import java.util.*
 import java.util.concurrent.TimeUnit
 import javax.inject.Inject
+import javax.inject.Singleton
 
-class DateUtil (
-    private val context: Context,
+@Singleton
+class DateUtil @Inject constructor (
+    @ApplicationContext private val context: Context,
     private val clock: Clock
 ) {
-    @Inject constructor(@ApplicationContext context: Context): this(context, AndroidClock)
-
     /**
      * If the message was sent/received on the same day we show: 12 hour time + am/pm
      *   12:43 pm
@@ -25,7 +25,7 @@ class DateUtil (
      *   09/03/23
      */
     @JvmOverloads
-    fun getDisplayFormattedTimeSpanString(timestamp: Long, locale: Locale = Locale.getDefault()): String {
+    fun format(timestamp: Long, locale: Locale = Locale.getDefault()): String {
         if (isWithin(timestamp, 1, TimeUnit.MINUTES)) {
             return context.getString(R.string.DateUtils_just_now)
         }
diff --git a/app/src/test/java/org/thoughtcrime/securesms/util/DateUtilTest.kt b/app/src/test/java/org/thoughtcrime/securesms/util/DateUtilTest.kt

Original file line number	Diff line number	Diff line change
`@@ -1728,7 +1728,7 @@ class ConversationActivityV2 : PassphraseRequiredActionBarActivity(), InputBarDe`
`1728`	`1728`	`val body = MentionUtilities.highlightMentions(message.body, viewModel.threadId, this)`
`1729`	`1729`	`if (TextUtils.isEmpty(body)) { continue }`
`1730`	`1730`	`if (messageSize > 1) {`
`1731`		`- val formattedTimestamp = dateUtil.getDisplayFormattedTimeSpanString(message.timestamp)`
	`1731`	`+ val formattedTimestamp = dateUtil.format(message.timestamp)`
`1732`	`1732`	`builder.append("$formattedTimestamp: ")`
`1733`	`1733`	`}`
`1734`	`1734`	`builder.append(body)`