Skip to content

Commit ccabed8

Browse files
authored
[sled-agent-types] move functional code to impls module (#9514)
In #9488 we moved versioned Sled Agent types to the sled-agent-types-versions crate. In that PR we moved functional code into that crate as well, living in the same files as types. However, dealing with updating this code can easily go wrong, particularly around merge conflicts. Move this kind of functional code to an `impls` module, so that it is always implemented on the latest versions of types.
1 parent 7618486 commit ccabed8

File tree

20 files changed

+1488
-1546
lines changed

20 files changed

+1488
-1546
lines changed

Cargo.lock

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sled-agent/src/sim/sled_agent.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ use sled_agent_types::early_networking::{
5757
};
5858
use sled_agent_types::instance::{
5959
InstanceEnsureBody, InstanceExternalIpBody, InstanceMulticastMembership,
60-
VmmPutStateResponse, VmmSpecExt, VmmStateRequested, VmmUnregisterResponse,
60+
VmmPutStateResponse, VmmStateRequested, VmmUnregisterResponse,
6161
};
6262
use sled_agent_types::inventory::{
6363
ConfigReconcilerInventory, ConfigReconcilerInventoryStatus,

sled-agent/types/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ schemars.workspace = true
2424
serde.workspace = true
2525
serde_human_bytes.workspace = true
2626
serde_json.workspace = true
27-
sha3.workspace = true
2827
sled-agent-types-versions.workspace = true
2928
sled-hardware-types.workspace = true
3029
slog.workspace = true

0 commit comments

Comments
 (0)