Skip to content

Commit d74f5e3

Browse files
authored
[reconfigurator-planning] be less noisy about steady state noop conversions (#9199)
Closes #9195.
1 parent 3a49cc7 commit d74f5e3

File tree

9 files changed

+66
-369
lines changed

9 files changed

+66
-369
lines changed

dev-tools/reconfigurator-cli/tests/output/cmds-mupdate-update-flow-stdout

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,7 +1109,6 @@ INFO BootPartitionDetails inventory hash not found in TUF repo, ignoring for noo
11091109
generated blueprint afb09faf-a586-4483-9289-04d4f1d8ba23 based on parent blueprint c1a0d242-9160-40f4-96ae-61f8f40a0b1b
11101110
blueprint source: planner with report:
11111111
planning report:
1112-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
11131112
* zone adds waiting on blockers
11141113
* zone adds and updates are blocked:
11151114
- current target release generation (3) is lower than minimum required by blueprint (4)
@@ -1291,7 +1290,6 @@ parent: c1a0d242-9160-40f4-96ae-61f8f40a0b1b
12911290

12921291
blueprint source: planner with report:
12931292
planning report:
1294-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
12951293
* zone adds waiting on blockers
12961294
* zone adds and updates are blocked:
12971295
- current target release generation (3) is lower than minimum required by blueprint (4)
@@ -1438,7 +1436,6 @@ INFO BootPartitionDetails inventory hash not found in TUF repo, ignoring for noo
14381436
generated blueprint ce365dff-2cdb-4f35-a186-b15e20e1e700 based on parent blueprint afb09faf-a586-4483-9289-04d4f1d8ba23
14391437
blueprint source: planner with report:
14401438
planning report:
1441-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
14421439
* noop converting 6/6 install-dataset zones to artifact store on sled d81c6a84-79b8-4958-ae41-ea46c9b19763
14431440
* zone adds waiting on blockers
14441441
* zone adds and updates are blocked:
@@ -1619,7 +1616,6 @@ parent: afb09faf-a586-4483-9289-04d4f1d8ba23
16191616

16201617
blueprint source: planner with report:
16211618
planning report:
1622-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
16231619
* noop converting 6/6 install-dataset zones to artifact store on sled d81c6a84-79b8-4958-ae41-ea46c9b19763
16241620
* zone adds waiting on blockers
16251621
* zone adds and updates are blocked:
@@ -1738,8 +1734,6 @@ INFO BootPartitionDetails inventory hash not found in TUF repo, ignoring for noo
17381734
generated blueprint 8f2d1f39-7c88-4701-aa43-56bf281b28c1 based on parent blueprint ce365dff-2cdb-4f35-a186-b15e20e1e700
17391735
blueprint source: planner with report:
17401736
planning report:
1741-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
1742-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 6 zones are already from artifacts
17431737
* zone adds waiting on blockers
17441738
* zone adds and updates are blocked:
17451739
- sleds have deployment units with image sources not set to Artifact:
@@ -1807,8 +1801,6 @@ INFO reached maximum number of pending MGS-driven updates, max: 1
18071801
generated blueprint 12d602a6-5ab4-487a-b94e-eb30cdf30300 based on parent blueprint 8f2d1f39-7c88-4701-aa43-56bf281b28c1
18081802
blueprint source: planner with report:
18091803
planning report:
1810-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
1811-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 6 zones are already from artifacts
18121804
* noop converting 7/7 install-dataset zones to artifact store on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c
18131805
* 1 pending MGS update:
18141806
* model0:serial0: RotBootloader(PendingMgsUpdateRotBootloaderDetails { expected_stage0_version: ArtifactVersion("0.0.1"), expected_stage0_next_version: NoValidVersion })
@@ -1992,8 +1984,6 @@ parent: 8f2d1f39-7c88-4701-aa43-56bf281b28c1
19921984

19931985
blueprint source: planner with report:
19941986
planning report:
1995-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
1996-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 6 zones are already from artifacts
19971987
* noop converting 7/7 install-dataset zones to artifact store on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c
19981988
* 1 pending MGS update:
19991989
* model0:serial0: RotBootloader(PendingMgsUpdateRotBootloaderDetails { expected_stage0_version: ArtifactVersion("0.0.1"), expected_stage0_next_version: NoValidVersion })
@@ -2179,9 +2169,6 @@ INFO some zones not yet up-to-date, zones_currently_updating: [ZonePropagationIn
21792169
generated blueprint 61a93ea3-c872-48e0-aace-e86b0c52b839 based on parent blueprint 12d602a6-5ab4-487a-b94e-eb30cdf30300
21802170
blueprint source: planner with report:
21812171
planning report:
2182-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 7 zones are already from artifacts
2183-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
2184-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 6 zones are already from artifacts
21852172
* noop converting host phase 2 slot B to Artifact on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c
21862173
* noop converting host phase 2 slot B to Artifact on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6
21872174
* noop converting host phase 2 slot B to Artifact on sled d81c6a84-79b8-4958-ae41-ea46c9b19763
@@ -2420,9 +2407,6 @@ INFO BootPartitionDetails inventory hash not found in TUF repo, ignoring for noo
24202407
generated blueprint 27e755bc-dc10-4647-853c-f89bb3a15a2c based on parent blueprint 61a93ea3-c872-48e0-aace-e86b0c52b839
24212408
blueprint source: planner with report:
24222409
planning report:
2423-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 7 zones are already from artifacts
2424-
* skipping noop zone image source check on sled c3bc4c6d-fdde-4fc4-8493-89d2a1e5ee6b: all 0 zones are already from artifacts
2425-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 6 zones are already from artifacts
24262410
* zone adds waiting on blockers
24272411
* zone adds and updates are blocked:
24282412
- current target release generation (4) is lower than minimum required by blueprint (5)
@@ -2555,9 +2539,6 @@ planning report:
25552539
planner config:
25562540
add zones with mupdate override: true
25572541

2558-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 7 zones are already from artifacts
2559-
* skipping noop zone image source check on sled c3bc4c6d-fdde-4fc4-8493-89d2a1e5ee6b: all 0 zones are already from artifacts
2560-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 6 zones are already from artifacts
25612542
* zone adds and updates are blocked:
25622543
- current target release generation (4) is lower than minimum required by blueprint (5)
25632544
- sleds have remove mupdate override set in blueprint: 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6

dev-tools/reconfigurator-cli/tests/output/cmds-nexus-generation-autobump-stdout

Lines changed: 3 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -941,10 +941,7 @@ INFO skipping board for MGS-driven update (no update necessary), serial_number:
941941
INFO ran out of boards for MGS-driven update
942942
generated blueprint 58d5e830-0884-47d8-a7cd-b2b3751adeb4 based on parent blueprint 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1
943943
blueprint source: planner with report:
944-
planning report:
945-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 9 zones are already from artifacts
946-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 8 zones are already from artifacts
947-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 8 zones are already from artifacts
944+
empty planning report
948945

949946

950947

@@ -1151,10 +1148,7 @@ parent: 8da82a8e-bf97-4fbd-8ddd-9f6462732cf1
11511148
PENDING MGS-MANAGED UPDATES: 0
11521149

11531150
blueprint source: planner with report:
1154-
planning report:
1155-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 9 zones are already from artifacts
1156-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 8 zones are already from artifacts
1157-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 8 zones are already from artifacts
1151+
empty planning report
11581152

11591153

11601154

@@ -1213,9 +1207,6 @@ INFO ran out of boards for MGS-driven update
12131207
generated blueprint 9034c710-3e57-45f3-99e5-4316145e87ac based on parent blueprint 7f976e0d-d2a5-4eeb-9e82-c82bc2824aba
12141208
blueprint source: planner with report:
12151209
planning report:
1216-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 9 zones are already from artifacts
1217-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 8 zones are already from artifacts
1218-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 8 zones are already from artifacts
12191210
* discretionary zones placed:
12201211
* nexus zone on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c from source artifact: version 1.0.0
12211212
* nexus zone on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6 from source artifact: version 1.0.0
@@ -1458,9 +1449,6 @@ INFO some zones not yet up-to-date, zones_currently_updating: [ZonePropagationIn
14581449
generated blueprint d60afc57-f15d-476c-bd0f-b1071e2bb976 based on parent blueprint 9034c710-3e57-45f3-99e5-4316145e87ac
14591450
blueprint source: planner with report:
14601451
planning report:
1461-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 10 zones are already from artifacts
1462-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1463-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
14641452
* zone updates waiting on zone propagation to inventory
14651453
* waiting to update top-level nexus_generation: new Nexus zones are not in inventory yet
14661454

@@ -1512,9 +1500,6 @@ INFO some zones not yet up-to-date, zones_currently_updating: [ZonePropagationIn
15121500
generated blueprint a5a8f242-ffa5-473c-8efd-2acf2dc0b736 based on parent blueprint d60afc57-f15d-476c-bd0f-b1071e2bb976
15131501
blueprint source: planner with report:
15141502
planning report:
1515-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 10 zones are already from artifacts
1516-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1517-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
15181503
* zone updates waiting on zone propagation to inventory
15191504
* waiting to update top-level nexus_generation: new Nexus zones are not in inventory yet
15201505

@@ -1553,9 +1538,6 @@ INFO ran out of boards for MGS-driven update
15531538
generated blueprint 626487fa-7139-45ec-8416-902271fc730b based on parent blueprint a5a8f242-ffa5-473c-8efd-2acf2dc0b736
15541539
blueprint source: planner with report:
15551540
planning report:
1556-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 10 zones are already from artifacts
1557-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1558-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
15591541
* 3 remaining out-of-date zones
15601542
* 3 zones waiting to be expunged:
15611543
* zone 0c71b3b2-6ceb-4e8f-b020-b08675e83038: nexus image out-of-date, but nexus_generation 1 is still active
@@ -1584,9 +1566,6 @@ INFO ran out of boards for MGS-driven update
15841566
generated blueprint c1a0d242-9160-40f4-96ae-61f8f40a0b1b based on parent blueprint 626487fa-7139-45ec-8416-902271fc730b
15851567
blueprint source: planner with report:
15861568
planning report:
1587-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 10 zones are already from artifacts
1588-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1589-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
15901569
* 3 remaining out-of-date zones
15911570
* 3 zones waiting to be expunged:
15921571
* zone 0c71b3b2-6ceb-4e8f-b020-b08675e83038: nexus image out-of-date, but nexus_generation 1 is still active
@@ -1619,9 +1598,6 @@ INFO ran out of boards for MGS-driven update
16191598
generated blueprint afb09faf-a586-4483-9289-04d4f1d8ba23 based on parent blueprint c1a0d242-9160-40f4-96ae-61f8f40a0b1b
16201599
blueprint source: planner with report:
16211600
planning report:
1622-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 10 zones are already from artifacts
1623-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1624-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
16251601
* 3 remaining out-of-date zones
16261602
* 3 zones waiting to be expunged:
16271603
* zone 0c71b3b2-6ceb-4e8f-b020-b08675e83038: nexus image out-of-date, but nexus_generation 1 is still active
@@ -1710,9 +1686,6 @@ INFO ran out of boards for MGS-driven update
17101686
generated blueprint ce365dff-2cdb-4f35-a186-b15e20e1e700 based on parent blueprint afb09faf-a586-4483-9289-04d4f1d8ba23
17111687
blueprint source: planner with report:
17121688
planning report:
1713-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 10 zones are already from artifacts
1714-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1715-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
17161689
* 3 remaining out-of-date zones
17171690
* 3 zones waiting to be expunged:
17181691
* zone 0c71b3b2-6ceb-4e8f-b020-b08675e83038: nexus image out-of-date, but nexus_generation 1 is still active
@@ -1772,9 +1745,6 @@ INFO ran out of boards for MGS-driven update
17721745
generated blueprint 8f2d1f39-7c88-4701-aa43-56bf281b28c1 based on parent blueprint ce365dff-2cdb-4f35-a186-b15e20e1e700
17731746
blueprint source: planner with report:
17741747
planning report:
1775-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 10 zones are already from artifacts
1776-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1777-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
17781748
* 1 out-of-date zone expunged:
17791749
* sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c, zone 466a9f29-62bf-4e63-924a-b9efdb86afec (nexus)
17801750
* 2 remaining out-of-date zones
@@ -1891,9 +1861,6 @@ INFO ran out of boards for MGS-driven update
18911861
generated blueprint 12d602a6-5ab4-487a-b94e-eb30cdf30300 based on parent blueprint 8f2d1f39-7c88-4701-aa43-56bf281b28c1
18921862
blueprint source: planner with report:
18931863
planning report:
1894-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 9 zones are already from artifacts
1895-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 9 zones are already from artifacts
1896-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
18971864
* 1 out-of-date zone expunged:
18981865
* sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6, zone 0c71b3b2-6ceb-4e8f-b020-b08675e83038 (nexus)
18991866
* 1 remaining out-of-date zone
@@ -2007,9 +1974,6 @@ INFO ran out of boards for MGS-driven update
20071974
generated blueprint 61a93ea3-c872-48e0-aace-e86b0c52b839 based on parent blueprint 12d602a6-5ab4-487a-b94e-eb30cdf30300
20081975
blueprint source: planner with report:
20091976
planning report:
2010-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 9 zones are already from artifacts
2011-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 8 zones are already from artifacts
2012-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 9 zones are already from artifacts
20131977
* 1 out-of-date zone expunged:
20141978
* sled d81c6a84-79b8-4958-ae41-ea46c9b19763, zone 3eeb8d49-eb1a-43f8-bb64-c2338421c2c6 (nexus)
20151979
* 0 remaining out-of-date zones
@@ -2124,10 +2088,7 @@ INFO skipping board for MGS-driven update (no update necessary), serial_number:
21242088
INFO ran out of boards for MGS-driven update
21252089
generated blueprint 27e755bc-dc10-4647-853c-f89bb3a15a2c based on parent blueprint 61a93ea3-c872-48e0-aace-e86b0c52b839
21262090
blueprint source: planner with report:
2127-
planning report:
2128-
* skipping noop zone image source check on sled 2b8f0cb3-0295-4b3c-bc58-4fe88b57112c: all 9 zones are already from artifacts
2129-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 8 zones are already from artifacts
2130-
* skipping noop zone image source check on sled d81c6a84-79b8-4958-ae41-ea46c9b19763: all 8 zones are already from artifacts
2091+
empty planning report
21312092

21322093

21332094

dev-tools/reconfigurator-cli/tests/output/cmds-noop-image-source-stdout

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,6 @@ INFO BootPartitionDetails inventory hash not found in TUF repo, ignoring for noo
431431
generated blueprint af934083-59b5-4bf6-8966-6fb5292c29e1 based on parent blueprint 58d5e830-0884-47d8-a7cd-b2b3751adeb4
432432
blueprint source: planner with report:
433433
planning report:
434-
* skipping noop zone image source check on sled 98e6b7c2-2efa-41ca-b20a-0a4d61102fe6: all 6 zones are already from artifacts
435434
* noop converting 2/2 install-dataset zones to artifact store on sled e96e226f-4ed9-4c01-91b9-69a9cd076c9e
436435
* zone adds waiting on blockers
437436
* zone adds and updates are blocked:

0 commit comments

Comments
 (0)