Skip to content
This repository was archived by the owner on Mar 13, 2020. It is now read-only.

Commit b7b9755

Browse files
authored
Fix audit command bug (#24)
* fix str join bug * add integration testing for audit command
1 parent bc9d228 commit b7b9755

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

appveyor.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ test_script:
5353
- test_full_refresh_from_mssql.cmd
5454
- test_incremental_refresh_from_csv.cmd
5555
- test_incremental_refresh_from_mssql.cmd
56+
- test_audit.cmd
5657

5758
- test_full_refresh_from_mssql.cmd
5859
- test_incremental_refresh_from_mssql.cmd
@@ -64,6 +65,7 @@ test_script:
6465
- sqlcmd -b -E -f 65001 -S "(local)\SQL2016" -d RelationalDataLoaderIntegrationTestSource -i .\integration_tests\mssql_source\source_database_setup\change_large_table.sql
6566

6667
- test_full_refresh_from_mssql.cmd
68+
- test_audit.cmd
6769

6870
on_finish:
6971
#Enable this line to make the build pause after completion for RDP troubleshooting.

rdl/RelationalDataLoader.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def execute_audit_command(self):
4747

4848
results = _AUDIT_FUNCTION_OPTIONS[self.args.model_type](data_load_tracker_repository, last_successful_timestamp)
4949

50-
print(results.join(" "))
50+
print(" ".join(results))
5151

5252
def configure_root_logger(self, log_level):
5353
# get the root logger

test_audit.cmd

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
py -m rdl audit postgresql+psycopg2://postgres:there_is_no_password_due_to_pg_trust@localhost/relational_data_loader_integration_tests FULL 2019-02-14T01:55:54.123456+00:00 --log-level INFO
2+
if %errorlevel% neq 0 exit /b %errorlevel%
3+
4+
py -m rdl audit postgresql+psycopg2://postgres:there_is_no_password_due_to_pg_trust@localhost/relational_data_loader_integration_tests INCR 2019-02-14T01:55:54.123456+00:00 --log-level INFO
5+
if %errorlevel% neq 0 exit /b %errorlevel%

0 commit comments

Comments
 (0)