-
-
Couldn't load subscription status.
- Fork 151
GH1419 Allow Series and Index for other in Index.where(..., other) #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the description in #1419, it seems the following tests are yet to be added:
- When the base instance is not of
DatetimeIndexbut just of a normalIndex,.wherealso works with the changes otherbeing aSeries
Please make the tests complete. Thanks!
|
Converting to draft until response from pandas team. |
|
Okay so this is allowed by pandas so I will clean the PR tonight. |
9c03aef to
c7d6823
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts so that we can merge 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @loicdiridollou !
Index.where(..., other)should supportotherwith more than array-like #1419assert_type()to assert the type of any return value