Removed type-casting shenanigans in array.py

Author: eicchen

pandas/core/arrays/arrow/array.py

@@ -906,11 +906,6 @@ def _evaluate_op_method(self, other, op, arrow_funcs) -> Self:
         ):
             if op in [operator.add, roperator.radd]:
                 sep = pa.scalar("", type=pa_type)
-                if not (is_scalar(other) or isinstance(other, pa.Scalar)):
-                    if len(other) == 0 or isna(other).any():
-                        other = other.cast(pa_type)
-                elif isna(other):
-                    other = other.cast(pa_type)
                 try:
                     if op is operator.add:
                         result = pc.binary_join_element_wise(self._pa_array, other, sep)

pandas/tests/arrays/integer/test_arithmetic.py

@@ -197,26 +197,6 @@ def test_error_invalid_values(data, all_arithmetic_operators):
         #  assert_almost_equal stricter, but the expected with pd.NA seems
         #  more-correct than np.nan here.
         tm.assert_series_equal(res, expected)
-    elif (
-        all_arithmetic_operators
-        in [
-            "__add__",
-            "__radd__",
-        ]
-        and pd.options.future.infer_string
-    ):
-        res = ops(str_ser)
-        if all_arithmetic_operators == "__radd__":
-            expected = pd.Series(
-                [np.nan if pd.isna(x) == 1 else "foo" + str(x) for x in data],
-                index=s.index,
-            )
-        else:
-            expected = pd.Series(
-                [np.nan if pd.isna(x) == 1 else str(x) + "foo" for x in data],
-                index=s.index,
-            )
-        tm.assert_series_equal(res, expected)
     else:
         with tm.external_error_raised(TypeError):
             ops(str_ser)