-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
TST: Replace ensure_clean_store with tmp_path in test_complex.py, test_file_handling.py #63214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
micol-altomare
wants to merge
13
commits into
pandas-dev:main
Choose a base branch
from
micol-altomare:micol-altomare-replace-ensure-clean-store
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14
−13
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b22b922
Replace ensure_clean_store with tmp_path fixture in test_file_handlin…
micol-altomare 49fcbd1
Update test_complex.py to check for tests
micol-altomare 8e5ef67
Fix isort failure in test_complex.py
micol-altomare 7c646a6
Replace ensure_clean_store with new fixture in test_complex.py
micol-altomare 08d4b91
Fix import ordering for pre-commit.ci test
micol-altomare e470c38
Fix pytables import in test_complex.py
micol-altomare 7e5acef
Fix CI failures due to imports in test_complex.py
micol-altomare 3056390
Fix typing error (specifically, isort) in test_complex.py
micol-altomare 6b4b9e7
Remove importorskip("tables") from test_complex.py
micol-altomare 06aaa4b
Retry microbamba error
micol-altomare 5e53038
Import pyables from pytables/common.py
micol-altomare 1c4afb4
Update to resolve microbamba error
micol-altomare 709b6c3
Remove tables import from test_complex.py
micol-altomare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mroeschke I added that line because
pytables(and its HDF5 dependency) aren't available in the Pyodide environment. Thus it skips those tests but keeps full test coverage where the dependency is present.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is effectively called in
pandas/tests/io/pytables/common.pyalready so it's not needed hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mroeschke Thanks! I have removed the
importorskip("tables")and includedfrom pandas.tests.io.pytables.common import tables.However, I'm seeing this error frequently come up:
Error: ENOENT: no such file or directory, lstat '/home/runner/work/_temp/setup-micromamba/micromamba-shell'This appears to be an issue with the post-run cleanup phase and seems unrelated to my changes. Could you please trigger a retry of the CI?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just remove these lines all together. I would consider this an unrelated change that can be addressed in a follow up if needed
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mroeschke Awesome, I just deleted those two lines as requested.
I still have failing automated tests, but I noticed that they're the same as what's failing in the main branch so they're unrelated to my changes. I believe it's ready for another review!