From 8b578c3b826076e6671829c5452ec3aecc21bee6 Mon Sep 17 00:00:00 2001 From: Vince Coccia Date: Mon, 20 Oct 2025 13:19:19 -0400 Subject: [PATCH 1/2] use the default python3 instead of specifying the minor version --- .pre-commit-config.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 9d94081..3b08292 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -4,17 +4,17 @@ repos: hooks: - id: black args: ['--skip-string-normalization'] - language_version: python3.10 + language_version: python3 - repo: https://github.com/pre-commit/pre-commit-hooks rev: v5.0.0 hooks: - id: trailing-whitespace - language_version: python3.10 + language_version: python3 - id: end-of-file-fixer - language_version: python3.10 + language_version: python3 - id: debug-statements - language_version: python3.10 + language_version: python3 - repo: https://github.com/pycqa/isort rev: 6.0.1 From 71a6647d1fe17ca41887e1b2a403c7c880d8b506 Mon Sep 17 00:00:00 2001 From: Vince Coccia Date: Mon, 20 Oct 2025 13:20:25 -0400 Subject: [PATCH 2/2] clean up my own hallucinations --- CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3b5d274..1dab54a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ Thank you for your interest in contributing to core-python! We welcome contribut 1. **Fork the repository** and create your branch from `master`. 2. **Create descriptive branches**: Use meaningful names, e.g., `feature/add-logging` or `bugfix/fix-typo-in-readme`. 3. **Write clear, concise commit messages** that explain your changes. -4. **Open a Pull Request** (PR) against the `master` branch. Please fill out the PR template and link any related issues. +4. **Open a Pull Request** (PR) against the `master` branch. ## Code Style & Quality @@ -17,17 +17,17 @@ Thank you for your interest in contributing to core-python! We welcome contribut ## Supported Versions -We support all current supported versions of Python. When introducing new dependencies or syntax, please ensure they are available and function correctly across all supported Python versions. +We support all current supported versions of Python. When introducing new dependencies or syntax, please ensure they are available and function correctly across all supported Python versions. If code requires version-specific logic, use clear and well-documented conditional statements. Please verify changes using the test suite in each supported Python environment. ## Testing - All new features and bugfixes must include tests. -- We use [pytest](https://docs.pytest.org/) for testing. Add your tests in the `tests/` directory. +- We use the python `unittest` module for testing to avoid additional dependencies. Add your tests in the `tests/` directory. - Ensure your code passes all tests before submitting a PR: ``` - pytest + python3 -m unittest ``` - We expect **100% test coverage** for new code (exceptions may be discussed in PRs).