[Bug Report]: Unintended transparency in various textures

[Mithi83]

Minecraft Version

1.21.1

Mod Version

1.6.2

Did you test the latest version?

No

Severity

Odd Results

NeoForge Version

21.1.211

Describe the Issue

On various textures I can see through parts I should not be able to see through:

I've checked in the source that the files in src\main\resources\assets\advanced_ae\textures\part

• stock_export_bus_back.png
• advanced_io_bus_back.png
• import_export_bus_back.png

contain transparent pixels that should most likely not be there. I've recently fixed a similar bug in AE2 itself: AppliedEnergistics/Applied-Energistics-2@240d08f

A similar bug in ExtendedAE was fixed by my commit in AE2, but here it cannot be applied that easily. Since fixing textures is not really that straight forward for me I chose to report it as a bug rather than editing the textures myself.

Reproduction Steps

Place a stock export bus, advanced io bus or import export bus and look at it from behind.

Screenshots and Videos

Problematic areas in the three files:

Additional Context

No response

Crash log

https://mclo.gs/AYQZbZf

[pedroksl]

I was aware of this issue when I made the textures. I did them like this mainly because I saw AE2 did it, and I wasn't sure if it was by design or a porting error. Addons also had this issue, so I just assumed it was by design. I will fix this, now that I know it wasn't. Thanks for the report.

[pedroksl]

Hey, sorry it took me so long to look into this.

I've just checked and my models use export_bus_base.json as their parent. Why didn't your fix apply to my models?

[Mithi83]

Yes, you use export_bus_base.json which I fixed in my AE2 patch by referencing the correct „back“ texture. In your models, you have that fixed json as the parent, but you override the „back“ texture with your own art, thus my fix cannot apply to your buses. E.g. here: https://github.com/pedroksl/AdvancedAE/blob/master/src/generated/resources/assets/advanced_ae/models/part/advanced_io_bus_part.json
You seem to have 3 individual copies of your modified „back“ texture, one for each of your export bus variants, each referenced in your 3 jsons. You could probably unify that into one back texture and one common json (e.g. advanced_ae_bus_base.json) if they are actually identical, which I did not check yet.
Sidenote: This fix is in the main branch but has not yet been included in an AE2 release.