TFS bug

[peonso]

Actual bug with TFS, nothing can be done at our side. This is hardcoded, should be commented out/removed:

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L70-L81

[Znote]

Did you post an issue about it on the TFS repo? Hardcoded itemids in C++ is bad. It should at least be from a configurable lua or xml file.

What about:
https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1237

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1315

https://github.com/otland/forgottenserver/blob/d934b569ad788f4be091f43e62cc4a66f4871ac0/src/item.cpp#L1379

[peonso]

@Znote I didn't noticed it because the pack didn't have those high ids. I also didn't posted it there because I didn't have a suggestion to address it.

[peonso]

https://github.com/otland/forgottenserver/blob/18fbfdc33a65c5cba9d5a02bcc8116dfd10362b0/src/protocolgame.cpp#L2631

https://github.com/otland/forgottenserver/blob/18fbfdc33a65c5cba9d5a02bcc8116dfd10362b0/src/protocolgame.cpp#L1444

[delconis]

I think this should be closed, this is old and the code has been TFS has been optimized