Skip to content

Conversation

@hieu2102
Copy link

The doc is missing finalizers.percona.com/delete-pxc-pods-in-order. This is the default finalizer as of pxc-db version 1.18.0:

The doc is missing `finalizers.percona.com/delete-pxc-pods-in-order`. 
This is the default `finalizer` as of `pxc-db` version `1.18.0`: 
- https://artifacthub.io/packages/helm/percona/pxc-db/?modal=values
- https://github.com/percona/percona-xtradb-cluster-operator/blob/main/deploy/cr.yaml
@nastena1606 nastena1606 requested a review from Copilot December 2, 2025 08:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the deletion documentation to reflect the addition of a new default finalizer (delete-pxc-pods-in-order) introduced in pxc-db version 1.18.0. The changes ensure the documentation accurately describes all available finalizers and their default configuration.

  • Updates the finalizer count from 3 to 4
  • Adds documentation for the delete-pxc-pods-in-order finalizer
  • Clarifies that delete-pxc-pods-in-order is now the default finalizer instead of having all finalizers off by default

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


* `finalizers.percona.com/delete-ssl`: if present, objects, created for SSL (Secret, certificate, and issuer) are deleted along with the cluster deletion.
* `finalizers.percona.com/delete-pxc-pods-in-order`: if present, PXC pods are deleted in order on cluster deletion (will not delete PVC).
* `finalizers.percona.com/delete-ssl`: if present, objects, created for SSL (Secret, certificate, and issuer) are deleted along with the cluster deletion (will not delete PVC).
Copy link

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The clarification '(will not delete PVC)' added to the delete-ssl finalizer is misleading. The delete-ssl finalizer is concerned with SSL-related objects (Secrets, certificates, issuers), not PVCs. This note should only appear on finalizers that could potentially affect PVCs but don't, or should be removed from this line.

Suggested change
* `finalizers.percona.com/delete-ssl`: if present, objects, created for SSL (Secret, certificate, and issuer) are deleted along with the cluster deletion (will not delete PVC).
* `finalizers.percona.com/delete-ssl`: if present, objects, created for SSL (Secret, certificate, and issuer) are deleted along with the cluster deletion.

Copilot uses AI. Check for mistakes.
@nastena1606 nastena1606 requested a review from egegunes December 2, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants