Cloud-926 Documented a note about deletion of user Secrets if delete-… #252
Conversation
…pvc finalizer is on
There was a problem hiding this comment.
Pull request overview
This PR documents the additional behavior of the percona.com/delete-pxc-pvc finalizer, which also deletes user Secrets when enabled. The documentation updates clarify this behavior across multiple sections to prevent unexpected data loss.
Key changes:
- Updated finalizer documentation to explicitly mention user Secrets deletion
- Added warnings about automatic Secret deletion when the finalizer is enabled
- Restructured the cleanup documentation to distinguish between automated and manual resource cleanup
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/operator.md | Added note that delete-pxc-pvc finalizer also deletes user Secrets |
| docs/delete.md | Updated finalizer description and added warnings about automatic Secret deletion behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| persistentvolumeclaim "datadir-cluster1-pxc-2" deleted | ||
| ``` | ||
|
|
||
| Note that it also deletes user secrets if you have enabled the `percona.com/delete-pxc-pvc` finalizer. To prevent it from happening, disable the finalizer. |
There was a problem hiding this comment.
This warning appears in the manual cleanup section (step 1 about deleting PVCs) but describes behavior of the automatic finalizer. The finalizer automatically deletes secrets during cluster deletion, not during manual PVC cleanup. This note should either be moved to the section about finalizers or clarified to explain it's about the alternative automated approach.
…pvc finalizer is on