Moving to XML::Sig - keeping them in sync is a pain

Author: timlegge

CONTRIBUTING.md

@@ -6,7 +6,7 @@ Issues should be reported at [Github Issue](https://github.com/perl-net-saml2/pe
 
 Future Plans:
 
-1. Move to configurable Certificate Verification with Crypt::OpenSSL::Verify replacing Crypt::OpenSSL::VerifyX509 as the default eventually
-2. Allow XML Signature Verification to be configurable with XML::Sig possibly replacing Net::SAML2::XML::Sig at the default eventually
+1. Move to configurable Certificate Verification with Crypt::OpenSSL::Verify replacing Crypt::OpenSSL::VerifyX509 as the default eventually - DONE
+2. Allow XML Signature Verification to be configurable with XML::Sig possibly replacing Net::SAML2::XML::Sig at the default eventually - DONE
 3. Allow the certificate files to be provided as text strings to allow applications to store the certificates in their native settings if needed
 4. We are open to other suggestions or improvements

Changes

@@ -2,6 +2,16 @@ Revision history for Perl extension Net::SAML2.
 
 {{$NEXT}}
 
+0.46 -- Thu Nov 25 21:53:52 AST 2021
+
+  - dd9776e Merge pull request #50 from timlegge/issue-38
+  - 54cf599 Testapp should display unicode
+  - ac74ac4 Fixes Issue #49 - Issue verifying XML that includes wide characters
+  - 5afc7dd Add strict and warnings to tests
+  - c20ed8c Add strict and warnings and move existing to the stop
+  - 26c53c1 v0.45
+  - 5397713 (tag: 0.45) Update for new version
+
 0.45 -- Wed Nov 17 17:33:34 AST 2021
 
   - 594d135 add missing use statement (ziali088)

Makefile.PL

@@ -16,19 +16,14 @@ my %WriteMakefileArgs = (
   "MIN_PERL_VERSION" => "5.008001",
   "NAME" => "Net::SAML2",
   "PREREQ_PM" => {
-    "Carp" => 0,
-    "Class::Accessor" => 0,
     "Crypt::OpenSSL::Bignum" => 0,
-    "Crypt::OpenSSL::DSA" => 0,
     "Crypt::OpenSSL::RSA" => 0,
     "Crypt::OpenSSL::Random" => 0,
     "Crypt::OpenSSL::Verify" => 0,
     "Crypt::OpenSSL::X509" => 0,
-    "Crypt::PK::ECC" => 0,
     "DateTime" => 0,
     "DateTime::Format::XSD" => 0,
     "DateTime::HiRes" => 0,
-    "Digest::SHA" => 0,
     "Exporter" => 0,
     "File::Slurp" => 0,
     "HTTP::Request::Common" => 0,
@@ -48,9 +43,9 @@ my %WriteMakefileArgs = (
     "URI::QueryParam" => 0,
     "XML::Generator" => 0,
     "XML::LibXML" => 0,
+    "XML::Sig" => "0.52",
     "XML::Writer" => "0.625",
     "base" => 0,
-    "constant" => 0,
     "namespace::autoclean" => 0,
     "strict" => 0,
     "vars" => 0,
@@ -71,27 +66,22 @@ my %WriteMakefileArgs = (
     "URI::URL" => 0,
     "XML::LibXML::XPathContext" => 0
   },
-  "VERSION" => "0.45",
+  "VERSION" => "0.47",
   "test" => {
     "TESTS" => "t/*.t t/author/*.t"
   }
 );
 
 
 my %FallbackPrereqs = (
-  "Carp" => 0,
-  "Class::Accessor" => 0,
   "Crypt::OpenSSL::Bignum" => 0,
-  "Crypt::OpenSSL::DSA" => 0,
   "Crypt::OpenSSL::RSA" => 0,
   "Crypt::OpenSSL::Random" => 0,
   "Crypt::OpenSSL::Verify" => 0,
   "Crypt::OpenSSL::X509" => 0,
-  "Crypt::PK::ECC" => 0,
   "DateTime" => 0,
   "DateTime::Format::XSD" => 0,
   "DateTime::HiRes" => 0,
-  "Digest::SHA" => 0,
   "Exporter" => 0,
   "File::Slurp" => 0,
   "HTTP::Request::Common" => 0,
@@ -124,9 +114,9 @@ my %FallbackPrereqs = (
   "XML::Generator" => 0,
   "XML::LibXML" => 0,
   "XML::LibXML::XPathContext" => 0,
+  "XML::Sig" => "0.52",
   "XML::Writer" => "0.625",
   "base" => 0,
-  "constant" => 0,
   "namespace::autoclean" => 0,
   "strict" => 0,
   "vars" => 0,

README

@@ -2,7 +2,7 @@ NAME
     Net::SAML2 - SAML2 bindings and protocol implementation
 
 VERSION
-    version 0.45
+    version 0.47
 
 SYNOPSIS
       See TUTORIAL.md for implementation documentation and

TUTORIAL.md

@@ -327,7 +327,7 @@ The handle_response() of the Net::SAML2::Binding::POST object processes the resp
 
 handle_response is pretty short but does a couple of important things:
 
-1. Calls Net::SAML2::XML::Sig to verify the signatures in the $saml_response XML
+1. Calls XML::Sig to verify the signatures in the $saml_response XML
 2. Verifies that the certificate that signed the XML was signed by the $cacert
 
 ### Get the Assertion from the SAMLResponse XML

cpanfile

@@ -1,18 +1,13 @@
 # Do not edit this file directly. To change prereqs, edit the `dist.ini` file.
 
-requires "Carp" => "0";
-requires "Class::Accessor" => "0";
 requires "Crypt::OpenSSL::Bignum" => "0";
-requires "Crypt::OpenSSL::DSA" => "0";
 requires "Crypt::OpenSSL::RSA" => "0";
 requires "Crypt::OpenSSL::Random" => "0";
 requires "Crypt::OpenSSL::Verify" => "0";
 requires "Crypt::OpenSSL::X509" => "0";
-requires "Crypt::PK::ECC" => "0";
 requires "DateTime" => "0";
 requires "DateTime::Format::XSD" => "0";
 requires "DateTime::HiRes" => "0";
-requires "Digest::SHA" => "0";
 requires "Exporter" => "0";
 requires "File::Slurp" => "0";
 requires "HTTP::Request::Common" => "0";
@@ -32,9 +27,9 @@ requires "URI::Encode" => "0";
 requires "URI::QueryParam" => "0";
 requires "XML::Generator" => "0";
 requires "XML::LibXML" => "0";
+requires "XML::Sig" => "0.52";
 requires "XML::Writer" => "0.625";
 requires "base" => "0";
-requires "constant" => "0";
 requires "namespace::autoclean" => "0";
 requires "perl" => "5.008_001";
 requires "strict" => "0";

dist.ini

@@ -59,6 +59,7 @@ skip = Saml2Test
 
 [Prereqs]
 Crypt::OpenSSL::Bignum = 0
+XML::Sig = 0.52
 
 [MetaJSON]
 [MetaProvides::Package]