ExtUtils-Constant: Update to 0.23_08

Minor C code improvements for croak_on_read, tested with -Wall -Wextra:
Correct MGVTBL for all versions, get_missing_hash not needed.

Author: rurban

Porting/Maintainers.pl

@@ -617,7 +617,7 @@ package Maintainers;
 
     'ExtUtils::Constant' => {
         # Upstream broken
-        'DISTRIBUTION' => 'RURBAN/ExtUtils-Constant-0.23_07.tar.gz',
+        'DISTRIBUTION' => 'RURBAN/ExtUtils-Constant-0.23_08.tar.gz',
         'FILES'    => q[dist/ExtUtils-Constant],
         'EXCLUDED' => [
             qw( lib/ExtUtils/Constant/Aaargh56Hash.pm

dist/ExtUtils-Constant/Changes

@@ -104,3 +104,13 @@ history can be found via http://perl5.git.perl.org/perl.git/tree/HEAD:/lib ]
         Fixed PROXYSUBS with all options but croak_on_read.
         Only one 5.6 PROXYSUBS autoload limitation in the error message
         on undefined macros.
+
+0.23_07 2017-04-24 rurban
+        Add benchmarking code and results. Recommended is PROXYSUBS or
+        PROXYSUBS autoload.
+        Silence cperl-only Used once warnings with PROXYSUBS push
+
+0.23_08 2017-04-25 rurban
+	Minor C code improvements for croak_on_read, tested with -Wall -Wextra:
+        Correct MGVTBL for all versions, get_missing_hash not needed.
+ 

dist/ExtUtils-Constant/README

@@ -38,11 +38,11 @@ use branch tables making the initial switch statements more efficient, and
 choosing a switch strategy to minimise the amount of linear searching of
 similar constant names.
 
-The best option seems to be PROXYSUBS without options, with the highest speed
-and on the lower side of memory usage.
-With a lot of macros, memory and speed is still not comparable to
-specialized perfect hashes, such as XSConfig or Win32::GUI::Constants
-though, but it is good enough for POSIX or Sockets.
+The best options seem to be PROXYSUBS or PROXYSUB autoload, with the
+highest speed and on the lower side of memory usage.  With a lot of
+macros, memory and speed is still not comparable to specialized
+perfect hashes, such as XSConfig or Win32::GUI::Constants though, but
+it is good enough for POSIX or Sockets.
 
 I believe ExtUtils::Constant is completely Unicode safe, but as a consequence
 of running various pathological cases as regression tests, the tests will

dist/ExtUtils-Constant/lib/ExtUtils/Constant.pm

@@ -1,6 +1,6 @@
 package ExtUtils::Constant;
 use vars qw (@ISA $VERSION @EXPORT_OK %EXPORT_TAGS);
-$VERSION = '0.23_07';
+$VERSION = '0.23_08';
 $VERSION = eval $VERSION;
 
 =head1 NAME
@@ -621,23 +621,21 @@ PROXYSUBS autoload is the slowest, but easiest to use.
 
 The old method without PROXYSUBS uses the most memory and is 2nd slowest.
 
-But with >500 constants the picture changes, with PROXYSUBS alone being
-the slowest, and PROXYSUBS autoload together with no options being the fastest,
-whilst with no options still using by far the most memory.
+With >500 constants:
 
     Option	        Memory [b]   Time [s]
     <none>              2572650	     0.025867
-    PROXYSUBS           2145701	     0.032594
-    PROXYSUBS autoload	2133418	     0.025888
-    PROXYSUBS push	2173807	     0.037089
+    PROXYSUBS           2145701	     0.024928
+    PROXYSUBS autoload	2133418	     0.024154
+    PROXYSUBS push	2173807	     0.030029
     PROXYSUBS 
-    croak_on_error	2142773	     0.026721
+    croak_on_error	2142773	     0.025776
     PROXYSUBS
-    croak_on_read	2145648	     0.027261
+    croak_on_read	2144780	     0.027649
     PROXYSUBS
-    autoload push	2161453	     0.026756
+    autoload push	2161453	     0.026092
     PROXYSUBS
-    croak_on_error push	2170791	     0.026831
+    croak_on_error push	2170791	     0.027433
 
 There are no numbers compared to perfect hashes yet. The estimation is
 that EU-C is ~50% slower and bigger, as seen with L<Win32::GUI::Constants>

dist/ExtUtils-Constant/lib/ExtUtils/Constant/Base.pm

@@ -5,7 +5,7 @@ use vars qw($VERSION);
 use Carp;
 use Text::Wrap;
 use ExtUtils::Constant::Utils qw(C_stringify perl_stringify);
-$VERSION = '0.23_07';
+$VERSION = '0.23_08';
 
 use constant is_perl56 => ($] < 5.007 && $] > 5.005_50);
 

dist/ExtUtils-Constant/lib/ExtUtils/Constant/ProxySubs.pm

@@ -3,7 +3,7 @@ use strict;
 use vars qw($VERSION @ISA %type_to_struct %type_from_struct %type_to_sv
 	    %type_to_C_value %type_is_a_problem %type_num_args
 	    %type_temporary);
-$VERSION = '0.23_07';
+$VERSION = '0.23_08';
 @ISA = 'ExtUtils::Constant::XS';
 
 =head1 NAME
@@ -443,8 +443,13 @@ static MGVTBL not_defined_vtbl = {
  0, /* len */
  0, /* clear */
  0, /* free */
+#if PERL_VERSION > 6
  0, /* copy */
  0, /* dup */
+#if (PERL_VERSION > 8) || (PERL_VERSION == 8 && PERL_SUBVERSION == 9)
+ 0, /* local */
+#endif
+#endif
 };
 
 EXPLODE
@@ -456,7 +461,7 @@ EXPLODE
     $key =~ s/::$//;
     my $key_len = length $key;
 
-    print $c_fh <<"MISSING";
+    print $c_fh <<"MISSING" unless $explosives;
 
 #ifndef SYMBIAN
 
@@ -589,11 +594,17 @@ EOBOOT
 					      $add_symbol_subname, $push);
     }
 
-    print $xs_fh <<"EOBOOT";
+    print $xs_fh <<'EOBOOT';
 	if (C_ARRAY_LENGTH(values_for_notfound) > 1) {
+EOBOOT
+
+    print $xs_fh <<"EOBOOT" unless $explosives;
 #ifndef SYMBIAN
 	    HV *const ${c_subname}_missing = get_missing_hash(aTHX);
 #endif
+EOBOOT
+
+    print $xs_fh <<'EOBOOT';
 	    const struct notfound_s *value_for_notfound = values_for_notfound;
 	    do {
 EOBOOT
@@ -603,7 +614,7 @@ EOBOOT
 		
 		sv_magicext(tripwire, 0, PERL_MAGIC_ext, &not_defined_vtbl, 0, 0);
 		SvPV_set(tripwire, (char *)value_for_notfound->name);
-		if(value_for_notfound->namelen >= 0) {
+		if (value_for_notfound->namelen >= 0) {
 		    SvCUR_set(tripwire, value_for_notfound->namelen);
 	    	} else {
 		    SvCUR_set(tripwire, -value_for_notfound->namelen);

dist/ExtUtils-Constant/lib/ExtUtils/Constant/Utils.pm

@@ -6,7 +6,7 @@ use Carp;
 
 @ISA = 'Exporter';
 @EXPORT_OK = qw(C_stringify perl_stringify);
-$VERSION = '0.23_07';
+$VERSION = '0.23_08';
 
 use constant is_perl55 => ($] < 5.005_50);
 use constant is_perl56 => ($] < 5.007 && $] > 5.005_50);

dist/ExtUtils-Constant/lib/ExtUtils/Constant/XS.pm

@@ -10,7 +10,7 @@ require ExtUtils::Constant::Base;
 @ISA = qw(ExtUtils::Constant::Base Exporter);
 @EXPORT_OK = qw(%XS_Constant %XS_TypeSet);
 
-$VERSION = '0.23_07';
+$VERSION = '0.23_08';
 
 $is_perl56 = ($] < 5.007 && $] > 5.005_50);
 

dist/Module-CoreList/lib/Module/CoreList.pm

@@ -14743,11 +14743,11 @@ our %delta = (
             'CPAN::Distribution'    => '2.18_01',
             'Cpanel::JSON::XS'      => '3.0231',
             'Cwd'                   => '4.67c',
-            'ExtUtils::Constant'            => '2.23_07',
-            'ExtUtils::Constant::Base'      => '2.23_07',
-            'ExtUtils::Constant::ProxySubs' => '2.23_07',
-            'ExtUtils::Constant::Utils'     => '2.23_07',
-            'ExtUtils::Constant::XS'        => '2.23_07',
+            'ExtUtils::Constant'            => '2.23_08',
+            'ExtUtils::Constant::Base'      => '2.23_08',
+            'ExtUtils::Constant::ProxySubs' => '2.23_08',
+            'ExtUtils::Constant::Utils'     => '2.23_08',
+            'ExtUtils::Constant::XS'        => '2.23_08',
             'ExtUtils::Install'             => '2.04_01',
             'ExtUtils::ParseXS'             => '3.34_02',
             'ExtUtils::ParseXS::Constants'  => '3.34_02',

pod/perlcdelta.pod

@@ -1208,7 +1208,7 @@ warnings has been to restricted to the four magic names "EXPORT",
 with "EXPORT" will now throw the "used only once" warning as all other
 symbols.
 
-=item ExtUtils-Constant 0.23_07
+=item ExtUtils-Constant 0.23_08
 
 Fix ProxySubs to generate code also valid for 5.6 - 5.14.
 Add testcases for all ProxySubs options.