From 84fb153cfa0b787e51a403be187e2fce081fb119 Mon Sep 17 00:00:00 2001 From: Charles Goldberg Date: Fri, 13 Mar 2026 16:21:03 -0600 Subject: [PATCH] fix: use pp-base-url input for review URLs instead of hardcoded domain The action was hardcoding 'permissionprotocol.com/review/' for the approval URL, which doesn't match the actual app route (/pp/deploy-requests/). Now uses the PP_BASE_URL env (from pp-base-url input, defaults to app.permissionprotocol.com) and the correct path. Also fixes docs (INSTALL.md, README.md) with correct URL paths. --- INSTALL.md | 6 +++--- README.md | 4 ++-- action.yml | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index b406517..84f5720 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -98,7 +98,7 @@ Open a PR to `main`. Deploy Gate always creates/verifies a PP request and posts A human must approve before merge. -👉 APPROVE HERE: https://app.permissionprotocol.com/review/dr_abc123 +👉 APPROVE HERE: https://app.permissionprotocol.com/pp/deploy-requests/dr_abc123 After approval, re-run this workflow. ═══════════════════════════════════════════════════════════ @@ -107,13 +107,13 @@ After approval, re-run this workflow. PR comment (auto-approved / verified): ```markdown ✅ **Permission Protocol:** Approved -[View receipt →](https://app.permissionprotocol.com/review/{requestId}) +[View receipt →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId}) ``` PR comment (approval required): ```markdown ⏳ **Permission Protocol:** Approval required -[Review & approve →](https://app.permissionprotocol.com/review/{requestId}) +[Review & approve →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId}) ``` --- diff --git a/README.md b/README.md index 29b367a..d27678e 100644 --- a/README.md +++ b/README.md @@ -218,13 +218,13 @@ Use this when you want custom scope values and auto-request creation in one work Auto-approved / verified: ```markdown ✅ **Permission Protocol:** Approved -[View receipt →](https://app.permissionprotocol.com/review/{requestId}) +[View receipt →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId}) ``` Approval required: ```markdown ⏳ **Permission Protocol:** Approval required -[Review & approve →](https://app.permissionprotocol.com/review/{requestId}) +[Review & approve →](https://app.permissionprotocol.com/pp/deploy-requests/{requestId}) ``` --- diff --git a/action.yml b/action.yml index c281671..53f4b50 100644 --- a/action.yml +++ b/action.yml @@ -284,7 +284,7 @@ runs: DIAG_KEY_STATUS=$(echo "$HTTP_BODY" | jq -r '.diagnostics.keyStatus // .result.diagnostics.keyStatus // empty' 2>/dev/null || echo "") if [ -n "$REQUEST_ID" ]; then - REVIEW_URL="https://permissionprotocol.com/review/${REQUEST_ID}" + REVIEW_URL="${PP_BASE_URL}/pp/deploy-requests/${REQUEST_ID}" else REVIEW_URL="$APPROVAL_URL" fi @@ -329,7 +329,7 @@ runs: echo " ${REVIEW_URL}" echo "" else - echo " 👉 https://permissionprotocol.com/review" + echo " 👉 ${PP_BASE_URL}/pp/deploy-requests" echo "" fi echo "═══════════════════════════════════════════════════════════"