-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Hello, I'm very happy to see this project, I will need something similar soon.
I think that a classic usage, documented in the readme, should be more similar to what we see in other existing datasources, where the user extends the datasource class to map his own API (https://www.apollographql.com/docs/apollo-server/data/data-sources/). Apollo datasource rest is even implemented as an abstract class to force you to do this, what do you think?
if you like to follow this path you might even have a more generic and caller-independent TTL configuration, just like in apollo datasource rest.
I also have some doubts about the forced inclusion of bunyan as logger, you shouldn't leave it free to those who use it? But on this I am very inexperienced and just curious about your choice.
Finally, I would be curious to know if you have other changes in mind to improve this project.
Thanks