fix tests: introduce rspec-puppet-facts

to only test supported OSes ;)

Author: igalic

Gemfile

@@ -2,19 +2,22 @@ source "https://rubygems.org"
 
 group :test do
   gem "rake"
-  gem "puppet", ENV['PUPPET_VERSION'] || '~> 3.4.0'
-  gem "puppet-lint"
+  gem "puppet", ENV['PUPPET_VERSION'] || '~> 3.7.0'
   gem "rspec-puppet", :git => 'https://github.com/rodjek/rspec-puppet.git'
-  gem "puppet-syntax"
   gem "puppetlabs_spec_helper"
+  gem "metadata-json-lint"
+  gem "rspec-puppet-facts"
+  gem "rspec", "< 3.2.0", { "platforms" => ["ruby_18"] }
 end
 
 group :development do
   gem "travis"
   gem "travis-lint"
-  gem "beaker"
-  gem "beaker-rspec"
-  gem "vagrant-wrapper"
   gem "puppet-blacksmith"
   gem "guard-rake"
 end
+
+group :system_tests do
+  gem "beaker"
+  gem "beaker-rspec"
+end

Rakefile

@@ -2,13 +2,16 @@ require 'puppetlabs_spec_helper/rake_tasks'
 require 'puppet-lint/tasks/puppet-lint'
 require 'puppet-syntax/tasks/puppet-syntax'
 
-# These two gems aren't always present, for instance
+# These gems aren't always present, for instance
 # on Travis with --without development
 begin
   require 'puppet_blacksmith/rake_tasks'
 rescue LoadError
 end
 
+Rake::Task[:lint].clear
+
+PuppetLint.configuration.relative = true
 PuppetLint.configuration.send("disable_80chars")
 PuppetLint.configuration.log_format = "%{path}:%{linenumber}:%{check}:%{KIND}:%{message}"
 PuppetLint.configuration.fail_on_warnings = true
@@ -20,6 +23,7 @@ PuppetLint.configuration.send('disable_class_parameter_defaults')
 PuppetLint.configuration.send('disable_class_inherits_from_params_class')
 
 exclude_paths = [
+  "bundle/**/*",
   "pkg/**/*",
   "vendor/**/*",
   "spec/**/*",
@@ -32,9 +36,14 @@ RSpec::Core::RakeTask.new(:acceptance) do |t|
   t.pattern = 'spec/acceptance'
 end
 
+task :metadata do
+  sh "metadata-json-lint metadata.json"
+end
+
 desc "Run syntax, lint, and spec tests."
 task :test => [
   :syntax,
   :lint,
   :spec,
+  :metadata,
 ]

spec/classes/libvirt_spec.rb

@@ -1,4 +1,4 @@
-#   Copyright 2013 Brainsware
+#   Copyright 2015 any number of authors
 #
 #   Licensed under the Apache License, Version 2.0 (the "License");
 #   you may not use this file except in compliance with the License.
@@ -15,18 +15,30 @@
 require 'spec_helper'
 
 describe 'libvirt', :type => :class do
-  let(:title) { 'libvirt' }
+  context 'supported operating systems' do
+    on_supported_os.each do |os, facts|
+      context "on #{os} #{facts}" do
+        let(:facts) do
+          facts
+        end
 
-  it { should contain_class('libvirt') }
-  it { should contain_file('/etc/libvirt/qemu/networks/autostart/default.xml') 
-       .with_ensure('absent')
-  }
+        context 'with default parameters' do
+          let(:title) { 'libvirt' }
 
-  describe 'with default network enabled' do
-    let(:params) {{ :defaultnetwork => true }}
+          it { should contain_class('libvirt') }
+          it { should contain_file('/etc/libvirt/qemu/networks/autostart/default.xml')
+               .with_ensure('absent')
+          }
+        end
 
-    it { should contain_class('libvirt') }
-    it { should contain_exec('virsh-net-autostart-default') }
+        context 'with default network enabled' do
+          let(:params) {{ :defaultnetwork => true }}
+
+          it { should contain_class('libvirt') }
+          it { should contain_exec('virsh-net-autostart-default') }
+        end
+      end
+    end
   end
 
 end

spec/spec_helper.rb

@@ -1 +1,10 @@
 require 'puppetlabs_spec_helper/module_spec_helper'
+require 'rspec-puppet-facts'
+include RspecPuppetFacts
+
+RSpec.configure do |c|
+  c.before do
+    # avoid "Only root can execute commands as other users"
+    Puppet.features.stubs(:root? => true)
+  end
+end