Add tests for void elements

peternewnham · peternewnham · commit 91729ec8aab7 · 2016-01-29T22:54:58.000Z
diff --git a/test/integration/integration.spec.js b/test/integration/integration.spec.js
@@ -73,4 +73,8 @@ describe('Integration tests: ', () => {
     test('<body>test</body>', '<div>test</div>');
   });
 
+  it('should not allow nesting of void elements', () => {
+    test('<img><p>test</p></img>', '<img/><p>test</p>');
+  });
+
 });
diff --git a/test/unit/elementTypes/TagElementType.spec.js b/test/unit/elementTypes/TagElementType.spec.js
@@ -1,16 +1,19 @@
 const GeneratePropsFromAttributes = jasmine.createSpy('GeneratePropsFromAttributes').and.callFake(attrs => attrs);
 const ProcessNodes = jasmine.createSpy('ProcessNodes').and.returnValue('children');
+const isVoidElement = jasmine.createSpy('isVoidElement').and.returnValue(false);
 
 const TagElementType = require('inject!elementTypes/TagElementType')({
   '../utils/GeneratePropsFromAttributes': GeneratePropsFromAttributes,
-  '../utils/ProcessNodes': ProcessNodes
+  '../utils/ProcessNodes': ProcessNodes,
+  '../utils/isVoidElement': isVoidElement
 }).default;
 
 describe('Testing `elementTypes/TagElementType', () => {
 
   beforeEach(() => {
     GeneratePropsFromAttributes.calls.reset();
     ProcessNodes.calls.reset();
+    isVoidElement.calls.reset();
   });
 
   it('should return a React element corresponding to the node name', () => {
@@ -33,4 +36,21 @@ describe('Testing `elementTypes/TagElementType', () => {
 
   });
 
+  it('should not pass though children for void elements', () => {
+
+    const voidNode = {
+      name: 'void',
+      attribs: {
+        id: 'test'
+      },
+      children: 'child'
+    };
+    isVoidElement.and.returnValue(true);
+
+    const voidElement = TagElementType(voidNode, 'key');
+    expect(voidElement.type).toBe('void');
+    expect(voidElement.props.children).toBe(null);
+
+  });
+
 });
diff --git a/test/unit/utils/isVoidElement.spec.js b/test/unit/utils/isVoidElement.spec.js
@@ -0,0 +1,12 @@
+import isVoidElement from 'utils/isVoidElement';
+
+describe('Testing `utils/isVoidElement`', () => {
+
+  it('should return whether the element is a void element', () => {
+    expect(isVoidElement('img')).toBe(true);
+    expect(isVoidElement('br')).toBe(true);
+    expect(isVoidElement('div')).toBe(false);
+    expect(isVoidElement('p')).toBe(false);
+  });
+
+});
