Single source version and update user agent string

See:
- https://www.python.org/dev/peps/pep-0440/
- https://python-packaging-user-guide.readthedocs.org/en/latest/single_source_version.html
- https://github.com/bitcoin/bips/blob/master/bip-0014.mediawiki

Author: welshjf

bitcoin/__init__.py

@@ -13,6 +13,11 @@
 
 import bitcoin.core
 
+# Note that setup.py can break if __init__.py imports any external
+# dependencies, as these might not be installed when setup.py runs. In this
+# case __version__ could be moved to a separate version.py and imported here.
+__version__ = '0.4.1.dev0'
+
 class MainParams(bitcoin.core.CoreMainParams):
     MESSAGE_START = b'\xf9\xbe\xb4\xd9'
     DEFAULT_PORT = 8333

bitcoin/messages.py

@@ -121,7 +121,8 @@ def __init__(self, protover=PROTO_VERSION):
         self.addrTo = CAddress(PROTO_VERSION)
         self.addrFrom = CAddress(PROTO_VERSION)
         self.nNonce = random.getrandbits(64)
-        self.strSubVer = b'/python-bitcoin-0.0.1/'
+        self.strSubVer = (b'/python-bitcoinlib:' +
+                          bitcoin.__version__.encode('ascii') + b'/')
         self.nStartingHeight = -1
 
     @classmethod

doc/conf.py

@@ -12,7 +12,6 @@
 # serve to show the default.
 
 PROJECT = 'python-bitcoinlib'
-VERSION = '0.4.0'
 DESCRIPTION = 'The Swiss Army Knife of the Bitcoin protocol.'
 AUTHORS = 'The python-bitcoinlib developers'
 
@@ -25,6 +24,8 @@
 # documentation root, use os.path.abspath to make it absolute, like shown here.
 sys.path.insert(0, os.path.abspath('..'))
 
+from bitcoin import __version__
+
 # Prevent loading openssl when generating API docs. Either the whole library or
 # the necessary elliptic curve might not be available, causing import to fail.
 try:
@@ -66,9 +67,9 @@
 # built documents.
 #
 # The short X.Y version.
-version = VERSION
+version = __version__
 # The full version, including alpha/beta/rc tags.
-release = VERSION
+release = __version__
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

setup.py

@@ -3,14 +3,16 @@
 from setuptools import setup, find_packages
 import os
 
+from bitcoin import __version__
+
 here = os.path.abspath(os.path.dirname(__file__))
 with open(os.path.join(here, 'README')) as f:
     README = f.read()
 
 requires = []
 
 setup(name='python-bitcoinlib',
-      version='0.4.1-SNAPSHOT',
+      version=__version__,
       description='The Swiss Army Knife of the Bitcoin protocol.',
       long_description=README,
       classifiers=[