Exceptions do not show rst line and file.

[pietvr]

When we have a '.. only' rst syntax error we see following output:

** Building RST documentation using Sphinx.

Exception occurred:
  File "/usr/local/lib/python3.7/dist-packages/sphinx/util/tags.py", line 68, in eval_condition
    raise ValueError('chunk after expression')
ValueError: chunk after expression
The full traceback has been saved in /tmp/sphinx-err-j_h31t85.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!

make: *** [Makefile:110: doc] Error 2
ERROR: Job failed: exit code 1

This is not very informative.
At the very least, useful would be to print the rst error line number and file.

Is this possible in this sphinx_selective_exclude?

The error in the '.. only' clause I added was not having a blank line after the '.. only' clause.

So this triggers this exception:

.. only:: SOMETHINGTRUE
   we want to write something without newline

[pfalcon]

Is this possible in this sphinx_selective_exclude?

I'm not sure what this phrase means.

And no, based on the exception you posted, it doesn't look like it comes from sphinx_selective_exclude.

[pietvr]

This phrase means that I'm not sure you can solve this in your plugin.
It could be that you need to be provided more information.
Is this any clear?

An example log can be found in sphinx-err.log.

[sphinx-err.log]
(https://github.com/pfalcon/sphinx_selective_exclude/files/3706947/sphinx-err.log)

In this file the last py print is:
File "/usr/local/lib/python3.7/dist-packages/sphinx_selective_exclude/eager_only.py", line 34, in run

For me this means the sphinx_selective_exclude/eager_only.py line 34 contains an error condition which is not caught properly in sphinx/util/tags.py.

So this bug could really be more of a sphinx issue, as you seem to imply.

tags.py.txt
eager_only.py.txt

[pietvr]

This seems more like a design flaw in sphynx.
In my opinion mostly 'raise' should print the rst file and line.

For a syntax error this is mandatory. (In my opinion)
For internal errors, this is a start for investigation. (In my opinion)
Always to be printed for uncatched raises ....

Or am I missing something?

[pietvr]

This eager_only.py file works for me.

I'm not sure it is correct.
I do not understand these sphinx variables given to .. only very well ...

eager_only.py.piet.txt

[pfalcon]

Thanks for investigating the issue and proposing a patch. I myself don't use sphinx_selective_exclude at this time (the project for which it was developed got converted to common documentation set). So, I apologize in advance if it may take quite some time before the PR is processed. It however should be of help for folks like yourself who experience this issue, so thanks for sharing!

[fpoirotte]

To add some more information, the full traceback ends with the following lines:

  File "/tmp/doc-test/sphinx_selective_exclude/sphinx_selective_exclude/eager_only.py", line 34, in run
    if not env.app.builder.tags.eval_condition(self.arguments[0]):
  File "/usr/lib/python2.6/site-packages/sphinx/util/tags.py", line 71, in eval_condition
    raise ValueError('chunk after expression')
ValueError: chunk after expression

I'm currently running an old version of Sphinx (v1.2.1) and I see the following code in sphinx.environment which is responsible for displaying a nice warning include the file/line number:

            try:
                ret = builder.tags.eval_condition(node['expr'])
            except Exception, err:
                self.warn_node('exception while evaluating only '
                               'directive expression: %s' % err, node)

Maybe the same mechanism could be implemented in this extension.

Regards