-
Notifications
You must be signed in to change notification settings - Fork 15
feat: include options in FlowShape for proper flow creation #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11-30-feat_edge-worker_add_ensure-compiled_endpoint_to_controlplane
Are you sure you want to change the base?
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 2e949b1
☁️ Nx Cloud last updated this comment at |
73a4f1d to
2e949b1
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-471.pgflow.pages.dev 📝 Details:
_Last updated: _ |

Include Options in FlowShape for Proper Flow Creation
This PR adds support for including flow and step options in the FlowShape structure, ensuring that options defined in the DSL are properly passed through to the database during flow creation.
Problem Fixed
Previously,
_create_flow_from_shape()was using default values instead of DSL-defined options, causing inconsistency between:compileFlow()→ SQL with optionsextractFlowShape()→_create_flow_from_shape()→ defaults onlyChanges
FlowShapeandStepShapeinterfaces to include optionaloptionsfieldsextractFlowShape()to include flow and step options in the shape_create_flow_from_shape()to pass options from shape tocreate_flow()Design Decision
Options are now included in the shape for proper flow creation, but are still excluded from shape comparison. This maintains the ability to tune options at runtime without triggering recompilation.
SQL functions now treat NULL parameters as "use default" via COALESCE, ensuring defaults are defined in a single place (inside the function) rather than being hardcoded by callers.