From 4a3de8c0305971c80f8f3c7a0abaad348794ba40 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Tue, 6 Jan 2026 21:09:19 -0800 Subject: [PATCH 1/3] 875_add_tests_format_data --- R/format_data.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/format_data.R b/R/format_data.R index 551d8f394..bd8aa284e 100644 --- a/R/format_data.R +++ b/R/format_data.R @@ -110,7 +110,7 @@ format_pkncaconc_data <- function(ADNCA, "INTRACARDIAC|INTRACORONARY)" ) ADNCA %>% - mutate( #round to prevent floating point precision issues + mutate(browser(), #round to prevent floating point precision issues dose_time = round(!!sym(time_column) - !!sym(rrlt_column), 6), std_route = ifelse( grepl(intravascular_pattern, gsub("[^[:alnum:]]", "", toupper(!!sym(route_column)))), From fce0b8d794b2b7c39d541ec81ad4e0458318e808 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Mon, 19 Jan 2026 22:34:01 -0800 Subject: [PATCH 2/3] 875 remove "browser()" in the mutate call R/format_data.R --- R/format_data.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/format_data.R b/R/format_data.R index bd8aa284e..551d8f394 100644 --- a/R/format_data.R +++ b/R/format_data.R @@ -110,7 +110,7 @@ format_pkncaconc_data <- function(ADNCA, "INTRACARDIAC|INTRACORONARY)" ) ADNCA %>% - mutate(browser(), #round to prevent floating point precision issues + mutate( #round to prevent floating point precision issues dose_time = round(!!sym(time_column) - !!sym(rrlt_column), 6), std_route = ifelse( grepl(intravascular_pattern, gsub("[^[:alnum:]]", "", toupper(!!sym(route_column)))), From e04f41709f6ab7c0d2e154a7dfa61fc0660ebd29 Mon Sep 17 00:00:00 2001 From: jimrothstein Date: Tue, 20 Jan 2026 21:37:24 -0800 Subject: [PATCH 3/3] 875 - test-format_data.R (placeholder) to test "nca_exclude_reason_columns" --- tests/testthat/test-format_data.R | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tests/testthat/test-format_data.R b/tests/testthat/test-format_data.R index b07d13262..0ef3b073d 100644 --- a/tests/testthat/test-format_data.R +++ b/tests/testthat/test-format_data.R @@ -37,6 +37,20 @@ describe("format_pkncaconc_data", { ) ) }) + + it("handles nca_exclude_reason_columns correctly", { + df_conc <- format_pkncaconc_data(ADNCA, + group_columns = c("STUDYID", "USUBJID", "PCSPEC", + "DOSETRT", "PARAM"), + time_column = "AFRLT", + rrlt_column = "ARRLT", + nca_exclude_reason_columns = c("RACE")) + + + expect_false(c("RACE") %in% colnames(df_conc)) + expect_s3_class(df_conc, "data.frame") + + }) it("filters EVID if column is present", { # Create base data with EVID = 0