Push buttons don't play sound if disposed when fired #967
Description
The work done in #957 caused some changes to the order of events that occur when a push button is fired. This caused a new, but potentially unimportant, problem: A button that is disposed in its fire listener does not play its sound. One proposal to fix this was to add a new emitter to PushButtonModel, one that fires before the button's listeners are fired. However, @pixelzoom, @jessegreenberg, and I discussed this and felt that the added complexity that this would introduce might not be worth it given the rarity of this use case. The one case we could think of where this might be a problem is in a dialog that is disposed when its "close" button is pushed, but even that seems unlikely given that a separate "close" sound would likely be used in the dialog itself. So here's the plan: Log this issue, defer it, and if no need arises to address it in the next, say, two years, we close it as "won't fix".