Skip to content

Commit b65597c

Browse files
author
Ryan P Kilby
authored
Improve RelatedFilter queryset error message (#170)
1 parent 790eab2 commit b65597c

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

rest_framework_filters/filters.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ def fset(self, value):
3939
def get_queryset(self, request):
4040
queryset = super(RelatedFilter, self).get_queryset(request)
4141
assert queryset is not None, \
42-
"Expected `.get_queryset()` to return a `QuerySet`, but got `None`."
42+
"Expected `.get_queryset()` for related filter '%s.%s' to return a `QuerySet`, but got `None`." \
43+
% (self.parent.__class__.__name__, self.name)
4344
return queryset
4445

4546

tests/test_filtering.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ class Meta:
347347
f.qs
348348

349349
msg = str(excinfo.exception)
350-
self.assertEqual("Expected `.get_queryset()` to return a `QuerySet`, but got `None`.", msg)
350+
self.assertEqual("Expected `.get_queryset()` for related filter 'NoteFilter.author' to return a `QuerySet`, but got `None`.", msg)
351351

352352
def test_relatedfilter_request_is_passed(self):
353353
class RequestCheck(FilterSet):

0 commit comments

Comments
 (0)