Fix methodfilter test to work on non-relationship filters

Author: Ryan P Kilby

tests/filters.py

@@ -71,14 +71,22 @@ class Meta:
         model = Post
 
     def filter_is_published(self, name, qs, value):
+        """
+        `is_published` is based on the actual `date_published`.
+        If the publishing date is null, then the post is not published.
+        """
+        # convert value to boolean
         null = value.lower() != 'true'
 
-        # 'post', 'is_published'
-        name, _ = name.rsplit(LOOKUP_SEP, 1)
+        # The lookup name will end with `is_published`, but could be
+        # preceded by a related lookup path.
+        if LOOKUP_SEP in name:
+            rel, _ = name.rsplit(LOOKUP_SEP, 1)
+            name = LOOKUP_SEP.join([rel, 'date_published__isnull'])
+        else:
+            name = 'date_published__isnull'
 
-        return qs.filter(**{
-            LOOKUP_SEP.join([name, 'date_published__isnull']): null
-        })
+        return qs.filter(**{name: null})
 
 
 class CoverFilterWithRelatedMethodFilter(FilterSet):

tests/test_filterset.py

@@ -22,7 +22,7 @@
     NoteFilterWithRelatedAll,
     NoteFilterWithRelatedAllDifferentFilterName,
     PostFilterWithRelated,
-    # PostFilterWithMethod,
+    PostFilterWithMethod,
     CoverFilterWithRelatedMethodFilter,
     CoverFilterWithRelated,
     # PageFilterWithRelated,
@@ -345,11 +345,20 @@ def generateTestData(cls):
         note2 = Note.objects.create(title="Test 2", content="Test content 2", author=user)
 
         post1 = Post.objects.create(note=note1, content="Test content in post 1")
-        post2 = Post.objects.create(note=note2, content="Test content in post 4", date_published=datetime.date.today())
+        post2 = Post.objects.create(note=note2, content="Test content in post 2", date_published=datetime.date.today())
 
         Cover.objects.create(post=post1, comment="Cover 1")
         Cover.objects.create(post=post2, comment="Cover 2")
 
+    def test_method_filter(self):
+        GET = {
+            'is_published': 'true'
+        }
+        filterset = PostFilterWithMethod(GET, queryset=Post.objects.all())
+        results = list(filterset)
+        self.assertEqual(len(results), 1)
+        self.assertEqual(results[0].content, "Test content in post 2")
+
     def test_related_method_filter(self):
         """
         Missing MethodFilter filter methods are silently ignored, returning