Skip to content

Commit 2df9565

Browse files
author
rakatyal
committed
Merge pull request #598 from phonegap-build/revert-435-master
Revert "Fix WP8 first register error"
2 parents da62e77 + 753012d commit 2df9565

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

src/ios/PushPlugin.m

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,10 +105,8 @@ - (void)register:(CDVInvokedUrlCommand*)command;
105105
UserNotificationTypes |= UIUserNotificationTypeAlert;
106106
#endif
107107
}
108-
109-
// Commented @see https://github.com/phonegap-build/PushPlugin/issues/365
110-
// notificationTypes |= UIRemoteNotificationTypeNewsstandContentAvailability;
111-
108+
109+
notificationTypes |= UIRemoteNotificationTypeNewsstandContentAvailability;
112110
#if __IPHONE_OS_VERSION_MAX_ALLOWED >= 80000
113111
UserNotificationTypes |= UIUserNotificationActivationModeBackground;
114112
#endif

src/wp8/PushPlugin.cs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public void register(string options)
2929
if (pushChannel == null)
3030
{
3131
pushChannel = new HttpNotificationChannel(this.pushOptions.ChannelName);
32-
SubscribePushChannelEvents(pushChannel);
32+
3333
try
3434
{
3535
pushChannel.Open();
@@ -43,10 +43,8 @@ public void register(string options)
4343
pushChannel.BindToShellToast();
4444
pushChannel.BindToShellTile();
4545
}
46-
else {
47-
SubscribePushChannelEvents(pushChannel);
48-
}
49-
46+
47+
SubscribePushChannelEvents(pushChannel);
5048
var result = new RegisterResult
5149
{
5250
ChannelName = this.pushOptions.ChannelName,

0 commit comments

Comments
 (0)