Merge pull request #198 from php-api-clients/ensure-correct-type-when-counting-LIST-items

Ensure correct type when counting LIST items

Author: WyriHaximus

src/Generator/Client.php

@@ -904,7 +904,11 @@ private static function callOperation(Routers $routers, Representation\Operation
                                 static fn (Expr $expr): Node\Stmt\Expression => new Node\Stmt\Expression(
                                     new Node\Expr\Assign(
                                         new Expr\Variable('items'),
-                                        $expr,
+                                        new Expr\Array_([
+                                            new Expr\ArrayItem(value: $expr, unpack: true),
+                                        ], [
+                                            'kind' => Node\Expr\Array_::KIND_SHORT,
+                                        ]),
                                     ),
                                 ),
                             ),

tests/app/etc/openapi-client-generator.state

@@ -216,11 +216,11 @@
             },
             {
                 "name": ".\/tests\/app\/src\/\/Router\/List\/Pets.php",
-                "hash": "2275eaa5b79fe7e404e44307c7bd611e"
+                "hash": "b6c6f9ea32f2797e49f62da95b2aa273"
             },
             {
                 "name": ".\/tests\/app\/src\/\/Router\/List\/PetsList.php",
-                "hash": "24686950c441b8eda04aebbe3b2ffd24"
+                "hash": "ba00aad83ddbfccd10c10038ca0ecebd"
             },
             {
                 "name": ".\/tests\/app\/src\/\/Router\/Post\/Pets.php",

tests/app/src/Router/List/Pets.php

@@ -37,7 +37,7 @@ public function listListing(array $params) : iterable
         $arguments['page'] = 1;
         do {
             $operator = new Operator\Pets\ListListing($this->browser, $this->authentication, $this->responseSchemaValidator, $this->hydrators->getObjectMapperOperation🌀Pets());
-            $items = $operator->call($arguments['per_page'], $arguments['page']);
+            $items = [...$operator->call($arguments['per_page'], $arguments['page'])];
             yield from $items;
             $arguments['page']++;
         } while (count($items) > 0);
@@ -61,7 +61,7 @@ public function namesListing(array $params) : iterable
         $arguments['page'] = 1;
         do {
             $operator = new Operator\Pets\NamesListing($this->browser, $this->authentication, $this->responseSchemaValidator, $this->hydrators->getObjectMapperOperation🌀Pets🌀Names());
-            $items = $operator->call($arguments['per_page'], $arguments['page']);
+            $items = [...$operator->call($arguments['per_page'], $arguments['page'])];
             yield from $items;
             $arguments['page']++;
         } while (count($items) > 0);

tests/app/src/Router/List/PetsList.php

@@ -37,7 +37,7 @@ public function gatosListing(array $params) : iterable
         $arguments['page'] = 1;
         do {
             $operator = new Operator\Pets\List_\GatosListing($this->browser, $this->authentication, $this->responseSchemaValidator, $this->hydrators->getObjectMapperOperation🌀Pets🌀Gatos());
-            $items = $operator->call($arguments['per_page'], $arguments['page']);
+            $items = [...$operator->call($arguments['per_page'], $arguments['page'])];
             yield from $items;
             $arguments['page']++;
         } while (count($items) > 0);