impl. Redis

Author: mvorisek

src/mutex/PHPRedisMutex.php

@@ -45,10 +45,12 @@ public function __construct(array $redisAPIs, string $name, float $timeout = 3)
      */
     protected function add($redisAPI, string $key, string $value, float $expire): bool
     {
+        $expireMillis = (int) ceil($expire * 1000);
+
         /** @var \Redis $redisAPI */
         try {
             //  Will set the key, if it doesn't exist, with a ttl of $expire seconds
-            return $redisAPI->set($key, $value, ['nx', 'ex' => $expire]);
+            return $redisAPI->set($key, $value, ['nx', 'px' => $expireMillis]);
         } catch (RedisException $e) {
             $message = sprintf(
                 "Failed to acquire lock for key '%s'",

src/mutex/PredisMutex.php

@@ -35,9 +35,11 @@ public function __construct(array $clients, string $name, float $timeout = 3)
      */
     protected function add($redisAPI, string $key, string $value, float $expire): bool
     {
+        $expireMillis = (int) ceil($expire * 1000);
+
         /** @var ClientInterface $redisAPI */
         try {
-            return $redisAPI->set($key, $value, 'EX', $expire, 'NX') !== null;
+            return $redisAPI->set($key, $value, 'PX', $expireMillis, 'NX') !== null;
         } catch (PredisException $e) {
             $message = sprintf(
                 "Failed to acquire lock for key '%s'",

tests/mutex/PredisMutexTest.php

@@ -53,7 +53,7 @@ public function testAddFailsToSetKey()
     {
         $this->client->expects($this->atLeastOnce())
             ->method('set')
-            ->with('lock_test', $this->isType('string'), 'EX', 4, 'NX')
+            ->with('lock_test', $this->isType('string'), 'PX', 4000, 'NX')
             ->willReturn(null);
 
         $this->logger->expects($this->never())
@@ -75,7 +75,7 @@ public function testAddErrors()
     {
         $this->client->expects($this->atLeastOnce())
             ->method('set')
-            ->with('lock_test', $this->isType('string'), 'EX', 4, 'NX')
+            ->with('lock_test', $this->isType('string'), 'PX', 4000, 'NX')
             ->willThrowException($this->createMock(PredisException::class));
 
         $this->logger->expects($this->once())
@@ -95,7 +95,7 @@ public function testWorksNormally()
     {
         $this->client->expects($this->atLeastOnce())
             ->method('set')
-            ->with('lock_test', $this->isType('string'), 'EX', 4, 'NX')
+            ->with('lock_test', $this->isType('string'), 'PX', 4000, 'NX')
             ->willReturnSelf();
 
         $this->client->expects($this->once())
@@ -119,7 +119,7 @@ public function testEvalScriptFails()
     {
         $this->client->expects($this->atLeastOnce())
             ->method('set')
-            ->with('lock_test', $this->isType('string'), 'EX', 4, 'NX')
+            ->with('lock_test', $this->isType('string'), 'PX', 4000, 'NX')
             ->willReturnSelf();
 
         $this->client->expects($this->once())