Faster smoke testing in CI

Author: mvorisek

.github/workflows/test-unit.yml

@@ -28,7 +28,6 @@ jobs:
 
       - name: Configure PHP
         run: |
-          install-php-extensions memcached sysvsem
           rm /usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
           php --version
 
@@ -37,6 +36,7 @@ jobs:
           if [ "${{ matrix.type }}" != "Phpunit" ] && [ "${{ matrix.type }}" != "StaticAnalysis" ]; then composer remove --no-interaction --no-update phpunit/phpunit ergebnis/phpunit-slow-test-detector --dev; fi
           if [ "${{ matrix.type }}" != "CodingStyle" ]; then composer remove --no-interaction --no-update friendsofphp/php-cs-fixer ergebnis/composer-normalize --dev; fi
           if [ "${{ matrix.type }}" != "StaticAnalysis" ]; then composer remove --no-interaction --no-update phpstan/\* --dev; fi
+          composer remove --no-interaction --no-update ext-lzf ext-memcached ext-sysvsem --dev
           composer update --ansi --prefer-dist --no-interaction --no-progress --optimize-autoloader
 
       - name: "Run tests (only for Phpunit)"

composer.json

@@ -39,11 +39,14 @@
         "symfony/polyfill-php80": "^1.28"
     },
     "require-dev": {
+        "ext-igbinary": "*",
+        "ext-lzf": "*",
         "ext-memcached": "*",
         "ext-pcntl": "*",
         "ext-pdo": "*",
         "ext-pdo_mysql": "*",
         "ext-pdo_sqlite": "*",
+        "ext-redis": "*",
         "ext-sysvsem": "*",
         "eloquent/liberator": "^2.0 || ^3.0",
         "ergebnis/composer-normalize": "^2.13",
@@ -62,7 +65,7 @@
     "suggest": {
         "ext-igbinary": "To use this library with PHP Redis igbinary serializer enabled.",
         "ext-lzf": "To use this library with PHP Redis lzf compression enabled.",
-        "ext-pnctl": "Enables locking with flock without busy waiting in CLI scripts.",
+        "ext-pcntl": "Enables locking with flock without busy waiting in CLI scripts.",
         "ext-redis": "To use this library with the PHP Redis extension.",
         "ext-sysvsem": "Enables locking using semaphores.",
         "predis/predis": "To use this library with predis."

src/Util/DoubleCheckedLocking.php

@@ -14,6 +14,8 @@
  *
  * You should not instantiate this class directly. Use
  * {@link \Malkusch\Lock\Mutex\Mutex::check()}.
+ *
+ * @internal
  */
 class DoubleCheckedLocking
 {

src/Util/Loop.php

@@ -13,14 +13,10 @@
  */
 class Loop
 {
-    /**
-     * Minimum time that we want to wait, between lock checks. In micro seconds.
-     */
+    /** Minimum time that we want to wait, between lock checks. In micro seconds. */
     private const MINIMUM_WAIT_US = 1e4; // 0.01 seconds
 
-    /**
-     * Maximum time that we want to wait, between lock checks. In micro seconds.
-     */
+    /** Maximum time that we want to wait, between lock checks. In micro seconds. */
     private const MAXIMUM_WAIT_US = 5e5; // 0.50 seconds
 
     /** @var float The timeout in seconds */

tests/Mutex/MutexConcurrencyTest.php

@@ -251,18 +251,20 @@ public static function provideExecutionIsSerializedWhenLockedCases(): iterable
             return $lock->popsValue();
         }];
 
-        yield 'semaphore' => [static function () use ($filename): Mutex {
-            $semaphore = sem_get(ftok($filename, 'b'));
-            self::assertThat(
-                $semaphore,
-                self::logicalOr(
-                    self::isInstanceOf(\SysvSemaphore::class),
-                    new IsType(IsType::TYPE_RESOURCE)
-                )
-            );
-
-            return new SemaphoreMutex($semaphore);
-        }];
+        if (extension_loaded('sysvsem')) {
+            yield 'semaphore' => [static function () use ($filename): Mutex {
+                $semaphore = sem_get(ftok($filename, 'b'));
+                self::assertThat(
+                    $semaphore,
+                    self::logicalOr(
+                        self::isInstanceOf(\SysvSemaphore::class),
+                        new IsType(IsType::TYPE_RESOURCE)
+                    )
+                );
+
+                return new SemaphoreMutex($semaphore);
+            }];
+        }
 
         if (getenv('MEMCACHE_HOST')) {
             yield 'memcached' => [static function ($timeout): Mutex {

tests/Mutex/MutexTest.php

@@ -81,9 +81,11 @@ public static function provideMutexFactoriesCases(): iterable
             return $lock->popsValue();
         }];
 
-        yield 'SemaphoreMutex' => [static function (): Mutex {
-            return new SemaphoreMutex(sem_get(ftok(__FILE__, 'a')));
-        }];
+        if (extension_loaded('sysvsem')) {
+            yield 'SemaphoreMutex' => [static function (): Mutex {
+                return new SemaphoreMutex(sem_get(ftok(__FILE__, 'a')));
+            }];
+        }
 
         yield 'SpinlockMutex' => [static function (): Mutex {
             $lock = new class('test') extends SpinlockMutex {