Merge pull request #5 from andrew-demb/do-not-extract-types-twice-on-fail

mmasiukevich · web-flow · commit 2704b02b0b73 · 2019-12-04T00:27:29.000+03:00
Do not extract types twice, when all inner extractors fails
diff --git a/src/Symfony/Extractor/FailOverExtractor.php b/src/Symfony/Extractor/FailOverExtractor.php
@@ -42,7 +42,7 @@ public function getTypes(string $class, string $property, array $context = []):
     {
         $cacheKey = \sha1($class . $property);
 
-        if (isset($this->localStorage[$cacheKey]) === false)
+        if (\array_key_exists($cacheKey, $this->localStorage) === false)
         {
             $this->localStorage[$cacheKey] = null;
 

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function getTypes(string $class, string $property, array $context = []):`
`42`	`42`	`{`
`43`	`43`	`$cacheKey = \sha1($class . $property);`
`44`	`44`
`45`		`- if (isset($this->localStorage[$cacheKey]) === false)`
	`45`	`+ if (\array_key_exists($cacheKey, $this->localStorage) === false)`
`46`	`46`	`{`
`47`	`47`	`$this->localStorage[$cacheKey] = null;`
`48`	`48`