Merge pull request #7 from andrew-demb/patch-1

Reuse phpunit `@require` to enable php 7.4 tests. Suppress less psalm issues

Author: mmasiukevich

psalm.xml

@@ -19,6 +19,10 @@
     </projectFiles>
 
     <issueHandlers>
-        <PropertyNotSetInConstructor errorLevel="suppress"/>
+        <PropertyNotSetInConstructor>
+            <errorLevel type="suppress">
+                <referencedProperty name="Symfony\Component\Serializer\SerializerAwareTrait::$serializer"/>
+            </errorLevel>
+        </PropertyNotSetInConstructor>
     </issueHandlers>
 </psalm>

src/Symfony/Extensions/PropertyNameConverter.php

@@ -24,7 +24,7 @@ final class PropertyNameConverter implements NameConverterInterface
      *
      * @psalm-var array<string, string>
      */
-    private $localStorage;
+    private $localStorage = [];
 
     /**
      * {@inheritdoc}

tests/Symfony/SymfonyMessageSerializerTest.php

@@ -244,48 +244,46 @@ static function (Author $author): string
     /**
      * @test
      *
+     * @requires PHP >= 7.4
+     *
      * @throws \Throwable
      */
     public function legacyPropertiesSupport(): void
     {
-        if (\PHP_VERSION_ID >= 70400)
-        {
-            $serializer = new SymfonyMessageSerializer();
-
-            $object = new MixedWithLegacy(
-                'qwerty',
-                new \DateTimeImmutable('2019-01-01', new \DateTimeZone('UTC')),
-                100500
-            );
-
-            /** @var MixedWithLegacy $unserialized */
-            $unserialized = $serializer->decode($serializer->encode($object));
-
-            static::assertSame($object->string, $unserialized->string);
-            static::assertSame($object->dateTime->getTimestamp(), $unserialized->dateTime->getTimestamp());
-            static::assertSame($object->long, $unserialized->long);
-        }
+        $serializer = new SymfonyMessageSerializer();
+
+        $object = new MixedWithLegacy(
+            'qwerty',
+            new \DateTimeImmutable('2019-01-01', new \DateTimeZone('UTC')),
+            100500
+        );
+
+        /** @var MixedWithLegacy $unserialized */
+        $unserialized = $serializer->decode($serializer->encode($object));
+
+        static::assertSame($object->string, $unserialized->string);
+        static::assertSame($object->dateTime->getTimestamp(), $unserialized->dateTime->getTimestamp());
+        static::assertSame($object->long, $unserialized->long);
     }
 
     /**
      * @test
      *
+     * @requires PHP >= 7.4
+     *
      * @throws \Throwable
      */
     public function privateMixedPropertiesSupport(): void
     {
-        if (\PHP_VERSION_ID >= 70400)
-        {
-            $serializer = new SymfonyMessageSerializer();
-
-            $object = new WithPrivateProperties(
-                'Some string',
-                100500,
-                now()
-            );
-
-            /** @var WithPrivateProperties $unserialized */
-            $unserialized = $serializer->decode($serializer->encode($object));
-        }
+        $serializer = new SymfonyMessageSerializer();
+
+        $object = new WithPrivateProperties(
+            'Some string',
+            100500,
+            now()
+        );
+
+        /** @var WithPrivateProperties $unserialized */
+        $unserialized = $serializer->decode($serializer->encode($object));
     }
 }