Rollback of the minimum php version to 7.3

Author: mmasiukevich

.travis.yml

@@ -1,6 +1,7 @@
 language: php
 
 php:
+  - 7.3
   - 7.4snapshot
 
 cache:
@@ -19,10 +20,9 @@ install:
 
 script:
   - ./vendor/bin/phpunit --configuration ./phpunit.xml --coverage-clover=coverage.clover
-  - ./vendor/bin/psalm --config=psalm.xml
-  - ./vendor/bin/phpstan analyse src --level 7
-  - ./vendor/bin/php-cs-fixer fix --allow-risky=yes --dry-run
+  - if [ "$TRAVIS_PHP_VERSION" == "7.4snapshot"]; then ./vendor/bin/psalm --config=psalm.xml; fi
+  - if [ "$TRAVIS_PHP_VERSION" == "7.4snapshot"]; then ./vendor/bin/php-cs-fixer fix --allow-risky=yes --dry-run; fi
 
 after_script:
-  - wget -c -nc --retry-connrefused --tries=0 https://scrutinizer-ci.com/ocular.phar
-  - php ocular.phar code-coverage:upload --format=php-clover coverage.clover
+  - if [ "$TRAVIS_PHP_VERSION" == "7.4snapshot"]; then wget -c -nc --retry-connrefused --tries=0 https://scrutinizer-ci.com/ocular.phar; fi
+  - if [ "$TRAVIS_PHP_VERSION" == "7.4snapshot"]; then php ocular.phar code-coverage:upload --format=php-clover coverage.clover; fi

composer.json

@@ -27,7 +27,7 @@
     }
   },
   "require": {
-    "php": ">=7.4",
+    "php": ">=7.3",
     "amphp/amp": "v2.4.*",
     "amphp/file": "v1.0.*"
   },

composer.lock

@@ -1,14 +1,16 @@
 <?xml version="1.0" encoding="UTF-8"?>
-
-<!-- https://phpunit.de/manual/current/en/appendixes.configuration.html -->
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/7.0/phpunit.xsd"
+<phpunit bootstrap="vendor/autoload.php"
          backupGlobals="false"
+         backupStaticAttributes="false"
+         beStrictAboutTestsThatDoNotTestAnything="false"
          colors="true"
-         bootstrap="vendor/autoload.php"
+         verbose="true"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
          failOnRisky="true"
          failOnWarning="true"
-         beStrictAboutTestsThatDoNotTestAnything="false">
+         stopOnFailure="false">
     <php>
         <ini name="error_reporting" value="-1"/>
     </php>

phpunit.xml

@@ -25,14 +25,14 @@ final class AmpLock implements Lock
      *
      * @var string
      */
-    private string $id;
+    private $id;
 
     /**
      * The function to be called on release or null if the lock has been released.
      *
      * @var \Closure|null
      */
-    private ?\Closure $releaser = null;
+    private $releaser = null;
 
     public function __construct(string $id, ?\Closure $releaser)
     {

src/AmpLock.php

@@ -34,18 +34,24 @@ final class FilesystemMutex implements Mutex
 
     /**
      * Mutex identifier.
+     *
+     * @var string
      */
-    private string $id;
+    private $id;
 
     /**
      * Barrier file path.
+     *
+     * @var string
      */
-    private string $filePath;
+    private $filePath;
 
     /**
      * Release handler.
+     *
+     * @var \Closure
      */
-    private \Closure $release;
+    private $release;
 
     public function __construct(string $id, string $filePath)
     {

src/FilesystemMutex.php

@@ -17,7 +17,8 @@
  */
 final class FilesystemMutexFactory implements MutexFactory
 {
-    private string $storageDirectory;
+    /** @var string */
+    private $storageDirectory;
 
     public function __construct(string $storageDirectory)
     {

src/FilesystemMutexFactory.php

@@ -28,10 +28,8 @@ final class InMemoryMutex implements Mutex
 {
     private const LATENCY_TIMEOUT = 10;
 
-    /**
-     * @var string
-     */
-    private string $id;
+    /**  @var string */
+    private $id;
 
     public function __construct(string $id)
     {

src/InMemoryMutex.php

@@ -20,9 +20,10 @@ final class InMemoryMutexStorage
     /**
      * @psalm-var array<string, bool>
      */
-    private array $localStorage = [];
+    private $localStorage = [];
 
-    private static ?self $instance = null;
+    /** @var self|null  */
+    private static $instance = null;
 
     /**
      * @return self